Header dependency missing

[ghost]

The header file here https://github.com/robosoft-ai/SMACC2/blob/humble/smacc2/include/smacc2/impl/smacc_orthogonal_impl.hpp
is unable to resolve the symbol demangeledtypes which is defined in samcc2::intropection.

It would be best if all header files are self contained to avoid confusion about which headers to include.

[brettpac]

Hi @emanodus can you be provide us with some more specifics please? Commands used, terminal output, system specifics, etc.

[ghost]

@brettpac
The things you requested for, for the most part, would be irrelevant to this issue. Second, I dont have the error anymore as i reolved it by including dependecy headers appropriately on my side. But i thought it would be meaningful to share this here.

I can describe in breif for more context to the issue. So I am extending SMACC2 for my specific use case, where I had to derive a new class from smacc2::Orthogonal<> class. For this I had to include this header "smacc_orthogonal_imp.hpp" in the header of my derived class. While I was building my derived class as a library I encountered an unresolved symbol error for "demangledTypeName" from here link . To resolve it I simply included impl/introspection/introspection.hpp in my derived class header.

I believe it would have been great if the smacc_orthogonal_impl.hpp header had included all headers which it depends on. Shouldn't all headers be self contained with all its dependecies? Please share your views. (I am afraid I am missing some rationale here)

[brettpac]

Hi @emanodus do you have a pull request we can look at?
We've been looking into this, but it would be much easier if we could just see the code. Thank you,