improve dynamic field loading #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a crude way to enable paramterization from the frontend before the setup phase is hit. It is not flexible in the sense that once the pre-game is over, no parameterization can be done anymore, but for now it should be a solid middle-ground until a nice and clean way of reconfiguring arbitrary yaml parameters at runtime is designed.
This fixes inconsistencies where multiple game-reports were maintained at the same time and also makes it simpler in general by basically only distinguishing whether a game report is present or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to easily allow teams to build their own field setups, save them and load them again with improved frontend-sided reconfiguration.
The workflow to modify and save a field is as follows:
The workflow to load the modified field is as follows:
Note: experienced users can of course pre-configure the yaml files of the refbox directly to always load the saved field.