Fix deprecation of strtoupper receiving null #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyvanlerberghe
force-pushed
the
fix-strtoupper-deprecation
branch
2 times, most recently
from
aa192a9 to
427f212
Compare
|
|
remyvanlerberghe
force-pushed
the
fix-strtoupper-deprecation
branch
from
427f212 to
c47fd49
Compare
rlanvin
added a commit
that referenced
this pull request
Jun 23, 2024
In some cases non-string types would end up passed to strtoupper which causes a deprecation warning from PHP 8.3. There might be other places where stricter type check is needed Ref #149
|
Hello, looking at this issue in more details I realised this isn't the right way to solve it. Non-string types shouldn't end up in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes following deprecation by moving exception throw before the call to
strtoupperDeprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in /app/vendor/rlanvin/php-rrule/src/RRule.php on line 242