Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/index #33

Merged
merged 21 commits into from
Dec 4, 2024
Merged

Feature/index #33

merged 21 commits into from
Dec 4, 2024

Conversation

josihoppe
Copy link
Collaborator

adding an index to the left sidebar with links for navigation

@josihoppe josihoppe requested a review from henhuy November 26, 2024 14:47
henhuy
henhuy requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@henhuy henhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my suggestions for better maintainability and easier implementation nof index. hope this helps! THx

building_dialouge_webapp/heat/navigation.py Outdated Show resolved Hide resolved
building_dialouge_webapp/heat/navigation.py Outdated Show resolved Hide resolved
building_dialouge_webapp/templates/base_flow.html Outdated Show resolved Hide resolved
building_dialouge_webapp/heat/flows.py Outdated Show resolved Hide resolved
building_dialouge_webapp/heat/flows.py Outdated Show resolved Hide resolved
building_dialouge_webapp/heat/flows.py Outdated Show resolved Hide resolved
josihoppe and others added 14 commits November 27, 2024 13:23
@josihoppe
merged base_flow and base_view
3fb32ce
@josihoppe
moved sidebar navigation mixin to navigation and get_flows into mixin
9205f07
@josihoppe
added finished method to flow and modified navigation
90f90ac
@josihoppe
added Renovation Flow
1d729d8
@henhuy
Fix checking if flow has finished
3215a6f
@henhuy
Allow clicking on non visited flows
5308a9f
@josihoppe
Merge branch 'feature/index' of https://github.com/rl-institut/bd_app …
d55e384 
…into feature/index
@henhuy
Minor change
fa570e5
@henhuy
Fix flow for non-required fields in forms
dc5561f
@henhuy
Fix status for unchanged forms with non-required fields
8bae014
@josihoppe
Merge pull request #34 from rl-institut/fix/non_required_fields
fe7d648 
Fix behaviour of flow for non-required fields
@josihoppe
changed navigation check for active to comparision with type of page
3a85f8e
@josihoppe
fixed visited and active for categories
b85b29d
@josihoppe
minor change
7943c53
@josihoppe josihoppe changed the base branch from main to dev December 4, 2024 13:06
@josihoppe josihoppe merged commit 568eb3a into dev Dec 4, 2024
@henhuy henhuy deleted the feature/index branch December 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henhuy henhuy henhuy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josihoppe @henhuy