Feature/forms #10
Merged
Feature/forms #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henhuy
requested changes
Jun 3, 2024
Comment on lines
22
to
26
| form_classes = [ | ||
| f | ||
| for f in globals().values() | ||
| if isinstance(f, type) and issubclass(f, forms.Form) | ||
| ] |
There was a problem hiding this comment.
Like the implementation, but I think it would be cleaner (more explicit) to simply have a list of Forms which should be shown on this view. Also, once we have an additional form in forms.py, which is not used on this view, we run into problems...
| all_valid = all(form.is_valid() for form in form_instances) | ||
|
|
||
| context = {"form_instances": form_instances} | ||
| if all_valid: |
There was a problem hiding this comment.
Here, you could check if some are not valid first, and return view with forms back to user showing the errors in the form.
|
Merged it already - will do form validation stuff later. Thx for fixing forms reading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.