-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows heap widget #2723
base: dev
Are you sure you want to change the base?
Windows heap widget #2723
Conversation
76e2837
to
430354c
Compare
return this->values.size(); | ||
} | ||
|
||
void HeapInfoModel::reload() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going through this freezes Cutter, the call to getWindowsHeaps should be done in an AsyncTask similar to Strings/FunctionsWidget.
Also worth trying to optimize rizin's side, listing an empty heap should take 20s+.
@PulakIIIT @yossizap @ITAYC0HEN @xarkes what is the status of this? |
There are still major performance issues on rizin's side that should be fixed before merging. |
@XVilka Need some performance improvements from Rizin side as heap parsing is very slow which causes cutter to hang up. I tried making the Rizin call async but encountered some crashes. At the moment I am busy with some real life stuff, planning to come back to this in a few weeks |
@PulakIIIT some types fixes were pushed to the latest master, please rebase your PR and resolve the conflicts. |
@PulakIIIT what are the current obstacles you are facing? :) |
Moving to the next milestone. |
@PulakIIIT, a lot has changed since, please resolve the conflicts and rebase against the latest |
@MalhotraPulak do you plan to work on this any time soon? |
Your checklist for this pull request
Detailed description
Initial implementation of windows heap widget
Shows the heap blocks in a table
Use Rizin from: rizinorg/rizin#1386
NOTE TYPES DO NOT WORK IN THIS PR
they were overhauled in new builds of rizin i will try to fix it once windows part is done
Test plan (required)
Closing issues