vfixed #220
Open
vfixed #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,15 +294,17 @@ void runTests(int argc, char **argv) | |||
| rob_tester.test_num_insts_retired(2); | |||
| rob_tester.test_num_uops_retired(5); | |||
| rob_tester.test_last_inst_has_tail(false); | |||
|
|
|||
| EXPECT_TRUE(my_vuop_generator->vuops_generated_.get() == 4); | |||
There was a problem hiding this comment.
Can you add this check to all of the vector tests? You can do it in a separate PR after you release this one.
| "vsaddu.vv" : {"pipe" : "vfixed", "uop_gen" : "ARITH", "latency" : 1}, | ||
| "vsaddu.vx" : {"pipe" : "vfixed", "uop_gen" : "ARITH", "latency" : 1}, | ||
| "vsaddu.vi" : {"pipe" : "vfixed", "uop_gen" : "ARITH", "latency" : 1}, | ||
| "vsaddu.vv" : {"pipe" : "vfixed", "uop_gen" : "ARITH", "latency" : 6}, |
There was a problem hiding this comment.
Please add a comment to the script that explains where these latencies came from.
kathlenemagnus-mips
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.