Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decode] vset_stats #218

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

orion160
Copy link
Collaborator

@orion160 orion160 commented Nov 3, 2024

No description provided.

@orion160 orion160 changed the title [decode] v_set_stats [decode] vset_stats Nov 3, 2024
@orion160 orion160 marked this pull request as ready for review November 8, 2024 00:34
@@ -20,6 +20,7 @@
#include "sparta/simulation/TreeNode.hpp"
#include "sparta/simulation/ParameterSet.hpp"

#include <cstdint>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be added?

{
updateVectorConfig_(inst);
}
else if (uid == MAVIS_UID_VSETVLI || uid == MAVIS_UID_VSETVL)
{
vset_blocking_count_++;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest per-increment to avoid the copy (although the compiler will do the right thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants