Mayne lsu #216
Draft
Mayne lsu #216
+147
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MayneMei Please reach out to Knute and see if he is available for a meeting to address your questions about debugging. |
klingaard
reviewed
Nov 10, 2024
| @@ -31,7 +33,7 @@ namespace olympia | |||
| cache_read_stage_(cache_lookup_stage_ | |||
| + 1), // Get data from the cache in the cycle after cache lookup | |||
| complete_stage_( | |||
| cache_read_stage_ | |||
| cache_read_stage_ | |||
There was a problem hiding this comment.
Please set up your editor to remove extraneous (dead) whitespace from end of lines.
| inst_ptr->isStoreInst() && (inst_ptr->getStatus() != Inst::Status::RETIRED); | ||
| const bool cache_bypass = is_already_hit || !phy_addr_is_ready || is_unretired_store; | ||
| //check if we can forward from store buffer first | ||
| uint64_t load_addr = inst_ptr->getTargetVAddr(); |
| ILOG("Store added to store buffer: " << inst_ptr); | ||
| } | ||
|
|
||
| LoadStoreInstInfoPtr LSU::findYoungestMatchingStore_(uint64_t addr) |
Comment on lines
+951
to
+961
| LoadStoreInstInfoPtr matching_store = nullptr; | ||
|
|
||
| for (auto it = store_buffer_.begin(); it != store_buffer_.end(); ++it) | ||
| { | ||
| auto & store = *it; | ||
| if (store->getInstPtr()->getTargetVAddr() == addr) | ||
| { | ||
| matching_store = store; | ||
| } | ||
| } | ||
| return matching_store; |
Comment on lines
+1452
to
+1453
| auto delete_iter = sb_iter++; | ||
| store_buffer_.erase(delete_iter); |
There was a problem hiding this comment.
Suggested change
| auto delete_iter = sb_iter++; | |
| store_buffer_.erase(delete_iter); | |
| sb_iter = store_buffer_.erase(sb_iter); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Arup and Knute, after I talked with Arup, I decided to implement store buffer first to enable data forwarding and then implement multi pipelines. Here is the draft pull. For my implementation, 30% tests passed, 69 tests failed out of 99, when I look those results I feel really lost on how to begin debug. Could you give me some guidance? Thank you!