Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument order in rust_io_uring_prep_splice #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mxxo
Copy link

@mxxo mxxo commented Nov 19, 2020

Hello! :)
This PR switches the order of fd_out and off_in in the io_uring_prep_splice call, I think they are incorrect as is.

The signature is off_in, fd_out and I changed the rusturing.c caller to match.

uring-sys/src/lib.rs

Lines 401 to 406 in 05bcecc

#[link_name = "rust_io_uring_prep_splice"]
pub fn io_uring_prep_splice(
sqe: *mut io_uring_sqe,
fd_in: libc::c_int,
off_in: libc::loff_t,
fd_out: libc::c_int,

@mxxo mxxo changed the title Fix argument order in io_uring_prep_splice Fix argument order in rust_io_uring_prep_splice Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant