Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blank dashboard page while the source is being ingested for the 1st time #6410

Merged
merged 1 commit into from
Jan 14, 2025
+2 −2
Merged

fix: blank dashboard page while the source is being ingested for the 1st time #6410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web-admin/src/routes/[organization]/[project]/explore/[dashboard]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@
$explore.error?.response?.status === 404;
// TODO: should these be checking metricsView or explore?
$: isDashboardReconcilingForFirstTime =
$explore?.data?.metricsView?.metricsView?.state?.validSpec === null &&
!$explore?.data?.metricsView?.metricsView?.state?.validSpec &&
!$explore?.data?.metricsView?.meta?.reconcileError;
// We check for metricsView.state.validSpec instead of meta.reconcileError. validSpec persists
// from previous valid dashboards, allowing display even when the current dashboard spec is invalid
// and a meta.reconcileError exists.
$: isDashboardErrored =
$explore?.data?.metricsView?.metricsView?.state?.validSpec === null &&
!$explore?.data?.metricsView?.metricsView?.state?.validSpec &&
!!$explore?.data?.metricsView?.meta?.reconcileError;
$: metricsViewName = $explore.data?.metricsView?.meta?.name?.name;

Expand Down
Loading