Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require explicit credentials for GCS, S3 sources #6398

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Require explicit credentials for GCS, S3 sources #6398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions runtime/drivers/gcs/gcs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,13 @@ var spec = drivers.Spec{
Required: true,
},
{
Key: "gcp.credentials",
Type: drivers.InformationalPropertyType,
Key: "google_application_credentials",
Type: drivers.FilePropertyType,
DisplayName: "GCP credentials",
Description: "GCP credentials inferred from your local environment.",
Hint: "Set your local credentials: <code>gcloud auth application-default login</code> Click to learn more.",
DocsURL: "https://docs.rilldata.com/reference/connectors/gcs#local-credentials",
Description: "GCP credentials file to use for authentication.",
Secret: true,
Required: false,
Hint: "Enter path of file to load from.",
},
},
ImplementsObjectStore: true,
Expand Down
26 changes: 18 additions & 8 deletions runtime/drivers/s3/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,24 @@ var spec = drivers.Spec{
Required: true,
Hint: "Glob patterns are supported",
},
{
Key: "aws_access_key_id",
Type: drivers.StringPropertyType,
DisplayName: "AWS Access Key ID",
Description: "AWS Access Key ID",
Placeholder: "AKIA1234567890ABCDEF",
Secret: true,
Required: true,
},
{
Key: "aws_secret_access_key",
Type: drivers.StringPropertyType,
DisplayName: "AWS Secret Access Key",
Description: "AWS Secret Access Key",
Placeholder: "your-aws-secret-access-key",
Secret: true,
Required: true,
},
{
Key: "region",
Type: drivers.StringPropertyType,
Expand All @@ -65,14 +83,6 @@ var spec = drivers.Spec{
Placeholder: "my_new_source",
Required: true,
},
{
Key: "aws.credentials",
Type: drivers.InformationalPropertyType,
DisplayName: "AWS credentials",
Description: "AWS credentials inferred from your local environment.",
Hint: "Set your local credentials: <code>aws configure</code> Click to learn more.",
DocsURL: "https://docs.rilldata.com/reference/connectors/s3#local-credentials",
},
},
ImplementsObjectStore: true,
}
Expand Down
Loading