-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak: admin improvements #6391
base: main
Are you sure you want to change the base?
Conversation
@briangregoryholmes I'm having trouble getting devtool to work but based on the screenshots, could you please update the underline of the selected tab to be gray-800 rather than the primary color? I think it should match the color of the tab text. |
@briangregoryholmes could you please add @ericokuma as a reviewer to this PR since he is the product owner for the associated PRD? |
I'm retracting this comment now that I've looked at the actual PR. Let's keep it primary. |
Thanks @briangregoryholmes! Couple of UXQA items:
|
Addressed all. As for the pinching, the problem is actually that those pages previously did not have a functional max width. They were defined only by strict x-axis padding. As such, there's really no previous size to return to. Because I don't think that was intended with the design, I've widened the allowed width for those pages to 1100 pixels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks way better! Approving from a general code perspective. I'll let @ericokuma give the final approval as Product Owner. And @lovincyrus please do look at the environment variable table.
Looks amazing @briangregoryholmes! Great job! |
https://www.notion.so/rilldata/Platform-Copy-label-improvements-10bba33c8f5780029a3efdc42b419c9c?pvs=4
Additional changes:
maxWidthOverride
prop structureCloses: #6358