make formatMsInterval tighter and add tests #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Dec 8, 2023
mindspank
pushed a commit
that referenced
this pull request
Dec 18, 2023
* make formatMsInterval tighter and add tests * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3655 -- this code is now as systematic as I know how to be in JS. Literally every everything value used in the function is either a literal of a defined type, a predefined constant field access, or a number, and any non-numeric input should be handle as well.
I was not able to reproduce the actual bug locally, so I can't 100% confirm that this will fix it, but it is now impossible to access the
unitfield on a possibly undefined value, because there is no more accessing of fields with runtime values.