Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text wrapping in the Imported Source dialog #3668

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Dec 8, 2023

Before: With short source names, "successfully" was often wrapped mid-word. With long source names, the header was hard to scan quickly.
image

After: This PR moves the source name out of the dialog's header and into its body.
image

image

@ericpgreen2 ericpgreen2 added the Type:Bug Something isn't working label Dec 8, 2023
@ericpgreen2 ericpgreen2 self-assigned this Dec 8, 2023
@briangregoryholmes
Copy link
Contributor

briangregoryholmes commented Dec 8, 2023

Works for me on a few different test names.

This is minor, but my instinct is that including the project name within this message isn't strictly necessary. When this modal appears, the project name is visible in two places elsewhere on the page. I think it might make sense for this to simply always say "Source imported successfully" without the name. The project name could be included on the next line in a lighter/smaller font if necessary. I think a confirmation message like this should be parseable with a really quick glance and the line break makes me take an extra second.

@ericpgreen2
Copy link
Contributor Author

This is minor, but my instinct is that including the project name within this message isn't strictly necessary. When this modal appears, the project name is visible in two places elsewhere on the page. I think it might make sense for this to simply always say "Source imported successfully" without the name. The project name could be included on the next line in a lighter/smaller font if necessary. I think a confirmation message like this should be parseable with a really quick glance and the line break makes me take an extra second.

Good idea – just incorporated. I did include the source name in the body of the dialog – because the dialog opens asynchronously, whenever the source finishes ingest, and if it's a long ingest, the user may have moved on to a different page.

@ericpgreen2 ericpgreen2 merged commit 7c667ed into main Dec 9, 2023
2 checks passed
@ericpgreen2 ericpgreen2 deleted the fix-text-wrap-on-imported-source-dialog branch December 9, 2023 17:45
esevastyanov pushed a commit that referenced this pull request Dec 13, 2023
* Only apply `break-all` to the source name

* Address feedback

(cherry picked from commit 7c667ed)
mindspank pushed a commit that referenced this pull request Dec 18, 2023
* Only apply `break-all` to the source name

* Address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants