Fix dashboard building check

rilldata · Jan 14, 2025 · f36ecc1 · f36ecc1
1 parent fa0b7d3
commit f36ecc1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/web-admin/src/routes/[organization]/[project]/explore/[dashboard]/+page.svelte b/web-admin/src/routes/[organization]/[project]/explore/[dashboard]/+page.svelte
@@ -64,13 +64,13 @@
     $explore.error?.response?.status === 404;
   // TODO: should these be checking metricsView or explore?
   $: isDashboardReconcilingForFirstTime =
-    $explore?.data?.metricsView?.metricsView?.state?.validSpec === null &&
+    !$explore?.data?.metricsView?.metricsView?.state?.validSpec &&
     !$explore?.data?.metricsView?.meta?.reconcileError;
   // We check for metricsView.state.validSpec instead of meta.reconcileError. validSpec persists
   // from previous valid dashboards, allowing display even when the current dashboard spec is invalid
   // and a meta.reconcileError exists.
   $: isDashboardErrored =
-    $explore?.data?.metricsView?.metricsView?.state?.validSpec === null &&
+    !$explore?.data?.metricsView?.metricsView?.state?.validSpec &&
     !!$explore?.data?.metricsView?.meta?.reconcileError;
   $: metricsViewName = $explore.data?.metricsView?.meta?.name?.name;