Skip to content

Commit

Permalink
Revert "Add a log for gcs usage (#6380)"
Browse files Browse the repository at this point in the history
This reverts commit 8f67eb2.
  • Loading branch information
himadrisingh committed Jan 14, 2025
1 parent 73173e0 commit 6bcb0ec
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions runtime/connection_cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"time"

"github.com/rilldata/rill/runtime/drivers"
"github.com/rilldata/rill/runtime/pkg/activity"
"github.com/rilldata/rill/runtime/pkg/conncache"
"github.com/rilldata/rill/runtime/pkg/observability"
"go.opentelemetry.io/otel/metric"
Expand Down Expand Up @@ -106,18 +105,10 @@ func (r *Runtime) openAndMigrate(ctx context.Context, cfg cachedConnectionConfig
}
}

r.Logger.Debug("opening connection", zap.String("instance_id", cfg.instanceID), zap.String("driver", cfg.driver), zap.String("name", cfg.name), zap.Bool("provision", cfg.provision))
handle, err := drivers.Open(cfg.driver, cfg.instanceID, cfg.config, r.storage.WithPrefix(cfg.instanceID, cfg.name), activityClient, logger)
if err == nil && ctx.Err() != nil {
err = fmt.Errorf("timed out while opening driver %q", cfg.driver)
}
r.activity.Record(ctx, "connection_open", activity.EventTypeLog,
attribute.String("instance_id", cfg.instanceID),
attribute.String("driver", cfg.driver),
attribute.String("name", cfg.name),
attribute.Bool("provision", cfg.provision),
attribute.Bool("success", err == nil),
)
if err != nil {
return nil, err
}
Expand Down

2 comments on commit 6bcb0ec

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Published on https://ui.rilldata.com as production
🚀 Deployed on https://6785f5253f13989036f6ce03--rill-ui.netlify.app

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.