Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install reStream downloading the latest release #53

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

f3fora
Copy link
Contributor

@f3fora f3fora commented Jan 29, 2021

People should download last release of reStream and not clone this repo.
I updated the README.md accordingly. See #50
Moreover, I change the structure of that file to avoid repetitions.

Copy link
Owner

@rien rien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed an improvement of the README, thanks!

There are a few minor things I'd like to see changed though.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@rien rien merged commit 49396e2 into rien:main Jan 29, 2021
@rien
Copy link
Owner

rien commented Jan 29, 2021

Thank you again!

@f3fora f3fora deleted the InstallReleaseREADME branch January 29, 2021 15:25
@f3fora
Copy link
Contributor Author

f3fora commented Jan 29, 2021

I think we made a mistake. We cannot use https://github.com/rien/reStream/releases/download/latest/..., but we have to use the version explicitly.

@rien
Copy link
Owner

rien commented Jan 29, 2021

Apparently we need to use https://github.com/rien/reStream/releases/latest/download/... (switch latest and download).

wget https://github.com/rien/reStream/releases/latest/download/reStream.sh works

@f3fora
Copy link
Contributor Author

f3fora commented Jan 29, 2021

Confirm.
At this point, I think it's easier to put a -i flag to install the binary directly, Something, like this.

release-"1.1"

...

	-i | --install)
            ssh $remarkable 'wget https://github.com/rien/reStream/releases/download/$release/restream.arm.static -O /home/root/restream && chmod +x /home/root/restream'
	    shift
	    ;;

In this way we avoid incompatible versions between host and remarkable.
If you want we can add also the other ways to get restream, but this increase the dependencies (wget on host or toltec on remarkable), and if we do not find restream binary on rm, echo "run reStream -i"

@rien
Copy link
Owner

rien commented Jan 29, 2021

Yes, this is part of what I want to implement with #50, but I would let the script ask to install or update.

@f3fora f3fora restored the InstallReleaseREADME branch January 29, 2021 16:53
@f3fora f3fora mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants