Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: replace deprecated github.com/golang/protobuf with google.golang.org/protobuf #21

Conversation

darccio
Copy link
Collaborator

@darccio darccio commented May 23, 2024

This PR replaces github.com/golang/protobuf with google.golang.org/protobuf because the former was deprecated in 2020, superseded by the latter.

It also regenerates src/proto/simple files using protoc and google.golang.org/protobuf/cmd/protoc-gen-go.

This is part of DataDog's effort to remove direct & indirect deprecated/vulnerable dependencies from dd-trace-go.

@richardartoul
Copy link
Owner

@darccio happy to merge, but CI is not happy right now. Do you mind taking a look? https://github.com/richardartoul/molecule/actions/runs/9205273283/job/25632220912?pr=21

@darccio
Copy link
Collaborator Author

darccio commented May 31, 2024

@richardartoul I see. Is it required to support Go 1.14? I merged master, so now CI should be fine with this PR aligned with your changes.

@richardartoul richardartoul merged commit 7ca0df4 into richardartoul:master May 31, 2024
1 check passed
@darccio darccio deleted the dario.castane/drop-deprecated-github-golang-protobuf branch June 3, 2024 10:50
@darccio
Copy link
Collaborator Author

darccio commented Jun 3, 2024

@richardartoul Thanks! Do you have any policy for maintenance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants