forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Trainer Battle Script Building #5938
Draft
u8-Salem
wants to merge
42
commits into
rh-hideout:upcoming
Choose a base branch
from
u8-Salem:trainerbattle_refactor
base: upcoming
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,057
−723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc49435.
u8-Salem
commented
Jan 3, 2025
Pawkkie
added
the
type: big feature
A feature with big diffs and / or high impact / subjectivity / pervasiveness
label
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: big feature
A feature with big diffs and / or high impact / subjectivity / pervasiveness
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a framework for dynamically generating trainer battle scripts and reworks how trainer battle parameters are stored
Description
I provided an in-depth explanation here
Short version:
In the current version different variations of trainerbattles such as playing the encounter music or not are handled as entirely different trainer battle types. This introduces a framework to dynamically build the trainer battle script, depending on the provided parameters. So if the parameter for 'play music' is given, then that part of the script will be executed vise versa.
Also allows for easy extension and introduction of new variations (e.g. applying some movement to the trainer before the battle starts).
Also consolidates all parameters into a struct that lives in EWRAM and is easily accessible and mutable.
Also makes first steps to more clearly separate different types into these categories:
Images
example of a simple modification with this framework:
Feature(s) this PR does NOT handle:
Things to note in the release changelog:
Discord contact info
u8.salem