Condense duplicate strings #5771
Conversation
| @@ -132,7 +132,7 @@ static void ContestEffect_UserLessEasilyStartled(void) | |||
| SetContestantEffectStringID(eContestAppealResults.contestant,CONTEST_STRING_STOPPED_CARING); | |||
| } | |||
|
|
|||
| // Slightly startles the POK�MON in front. | |||
| // Slightly startles the POKéMON in front. | |||
There was a problem hiding this comment.
Looks like the script has messed up és.
There was a problem hiding this comment.
Are they messed up for you? I changes them because they were originally incompatible with python’s regex and showing up as invalid characters in VSCode. They show up as é just fine on GitHub on my end, too.
There was a problem hiding this comment.
They look like this to me:
There was a problem hiding this comment.
Weird, it looks like that on GitHub to me too (at least on my computer, on my phone it looks fine). The diff locally in VSCode (and GitHub Desktop, for reference) looks like I fixed it, if anything:
It's weird how this file is the only case where é seems to pose any trouble at all, and I'm not sure why
There was a problem hiding this comment.
It's probably bad system defaults and mixed character encodings crawling in from somewhere.
Edu's screenshot shows an UTF-8 é decoded in ANSI. Python's regexp works in UTF-8, so it's likely that this file ended up with a mixed encoding which throws off autodetection.
A future-proof solution would be to apply encoding=utf-8 to all source files' .gitattributes and review/fix the ANSI remnants within a single run.
This PR removes all duplicate strings to allow for easier editing on a larger scale, as well for an easier overview on what is actually being displayed.
As a proof of concept, I have only removed the duplicate empty strings (if not aligned to make sure compatibility is preserved). I have a python script locally (will add it to the final repo) that informs me of many other duplicates. Please let me know if this work is satisfactory or if we should not be bothering with this.
Things to note in the release changelog:
Discord contact info
bassoonian