Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement websocket interaction between server and client #8

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

rgallor
Copy link
Owner

@rgallor rgallor commented May 26, 2023

Define shell.rs to handle the execution of shell commands.
Define device_server.rs to handle messages from clients.
Define sender_client.rs to send shell commands to the server and handle responses.
Define io_handler.rs to handle stdin/stdout operations.

Close #3

@rgallor rgallor requested a review from harlem88 May 26, 2023 15:40
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Merging #8 (18ad124) into main (b505ae9) will not change coverage.
The diff coverage is 0.0%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted Files Coverage Δ
cli/src/main.rs 0.0% <0.0%> (ø)
rust-remote-shell/src/device_server.rs 0.0% <0.0%> (ø)
rust-remote-shell/src/io_handler.rs 0.0% <0.0%> (ø)
rust-remote-shell/src/sender_client.rs 0.0% <0.0%> (ø)
rust-remote-shell/src/shell.rs 0.0% <0.0%> (ø)

rgallor added 10 commits June 6, 2023 18:14
Implement server functionality capable of creating new connections using websocket and execuring shell commands.
Partially implement error handling.

Signed-off-by: rgallor <[email protected]>
Signed-off-by: rgallor <[email protected]>
rust-remote-shell/src/device_server.rs Outdated Show resolved Hide resolved
rust-remote-shell/src/io_handler.rs Outdated Show resolved Hide resolved
rust-remote-shell/src/io_handler.rs Show resolved Hide resolved
rust-remote-shell/src/shell.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@harlem88 harlem88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all certificates and keys from the repo, if they are useful for the project add a minimal guideline to generate them.

certs/localhost.local+1-key.pem Outdated Show resolved Hide resolved
@rgallor rgallor force-pushed the websocket branch 2 times, most recently from 957b2bc to c8116f9 Compare June 27, 2023 12:46
Signed-off-by: rgallor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a transport-layer for receiving a command
3 participants