Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: keep structure if only one adduct #107

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix: keep structure if only one adduct #107

merged 2 commits into from
Oct 18, 2023

Conversation

philouail
Copy link
Collaborator

Needed to retrain the matrix structure that drops if the code is ran with only one adduct.

@philouail philouail requested a review from jorainer October 17, 2023 14:49
jorainer
jorainer requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@jorainer jorainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please increase the version of the package in DESCRIPTION and also add an entry to the NEWS.md to describe this bug fix?

@philouail philouail requested a review from jorainer October 18, 2023 09:47
@philouail philouail marked this pull request as draft October 18, 2023 09:54
@philouail philouail marked this pull request as ready for review October 18, 2023 10:17
jorainer
jorainer approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@jorainer jorainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks for the PR @philouail !

@jorainer jorainer merged commit 7a08337 into main Oct 18, 2023
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorainer jorainer jorainer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philouail @jorainer