fix(settings): fixed inability to rename categories when they have blank names #1050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue where using blank names in categories would lead to them being permanently* stuck as such.
Blank names are already prohibited, evident from the 400 error you receive if you try creating a category without entering anything in the name field. For some reason though, simple whitespace characters (including U+0020) are allowed. When this happens, the category gets stuck with a blank name due to the
<span>
element ending up with a size of 0x0, and since the click handler responsible for allowing the user to rename the category is attached to that same<span>
element, you can kinda see how it goes wrong.I realize that a change to the backend to improve handling of whitespace characters would be the more ideal solution, but this change on the frontend is incredibly simple, and it would also be nice for handling future edge cases if a similar exploit is found again.
*unless you have access to devtools, of course.
Please make sure to check the following tasks before opening and submitting a PR