API - Style: Bring back 'boxShadow' style property #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
commented
Jan 17, 2020
| Style.[ | ||
| backgroundColor(Colors.blue), | ||
| position(`Relative), | ||
| width(100), | ||
| height(100), | ||
| boxShadow( |
There was a problem hiding this comment.
FYI @glennsl - I reverted the example so we could show the boxShadow API in the context of styles
…ryphe/revery into api/style/bring-back-boxshadow
…ryphe/revery into api/style/bring-back-boxshadow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the
boxShadowproperty to help unblock shadows for this PR: onivim/oni2#1211The problem with
<BoxShadow />, in its current form, is that it impacts both layout and events. This is a more general blocker to implementing the 'composition components' design here: #489A component like
<BoxShadow />should purely be about drawing, and not impact layout / or event handling - it's very confusing if it interferes with that!In order to implement this properly - we'll likely have to revisit our underlying component model, and create lower level primitives representing:
The main problem is that in our current
nodeobject hierarchy, eachnodeis responsible for all three of those - and thus, any intermediate node impacts all of those systems.