Ovs flows

[vlrpl]

extract ufid and other info

[vlrpl]

Functional tests are currently broken because of an issue in Vagrant 2.4.2.

[amorenoz]

Not a full review, just a comment that came up when integrating.

I had this:

#[event_type]
#[derive(Copy, Default, PartialEq)]
pub struct UFID {
    parts: [u32; 4],
}

Looking at the convention taken elsewhere I think your name is probably preferred.

However, whether to use tuple vs named struct took me some thinking. I think tuples are nice if you don't use inner objects too much or else self.0 is a bit confusing to me when reading. Having it pub is definitely a red flag, even more in this case where UFID.0 could be thought to be the first 32bit part.

Why did you need it to be public?
Also, note that internal members of event_types are accessed directly in python and tuples are a bit confusing (#437).

[amorenoz]

How about this for a middle ground?

#[event_type]
#[derive(Copy, Default, PartialEq)]
pub struct UFID(pub u32, pub u32, pub u32, pub u32);

[vlrpl]

Not a full review, just a comment that came up when integrating.

I had this:

#[event_type]
#[derive(Copy, Default, PartialEq)]
pub struct UFID {
    parts: [u32; 4],
}

Looking at the convention taken elsewhere I think your name is probably preferred.

However, whether to use tuple vs named struct took me some thinking. I think tuples are nice if you don't use inner objects too much or else self.0 is a bit confusing to me when reading. Having it pub is definitely a red flag, even more in this case where UFID.0 could be thought to be the first 32bit part.

Why did you need it to be public? Also, note that internal members of event_types are accessed directly in python and tuples are a bit confusing (#437).

No real reason. TBF, this was simply quicker to write&share to unblock the other part of the work.
Something like this will have been the final intended form:

impl Ufid {
    pub fn new_or_from_whatever(ufid: [u32; 4]) -> Self {
        Self(ufid)
    }
}

[vlrpl]

How about this for a middle ground?

#[event_type]
#[derive(Copy, Default, PartialEq)]
pub struct UFID(pub u32, pub u32, pub u32, pub u32);

Having parts accessible with this form sgtm.