User defined probe UX improvements #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the probe type optional when using a tracepoint; one can use `-p skb:kfree_skb` instead of `-p tp:skb:kfree_skb`. The logic is as follow: - If a probe type is explicitly given, we're using it. - If no probe type is given: + If a single ':' is found, defaults to 'raw_tracepoint'. + If no ':' is found, defaults to 'kprobe'. Note that default probe types are not considered stable and might evolve over time (and this was never the intent). Update the help accordingly. Signed-off-by: Antoine Tenart <[email protected]>
Probe types are reported using abbreviations in the events output. Also 'tp' was already accepted instead of 'raw_tracepoint' when adding a user-defined probe. Extend the logic to cover kprobes and kretprobes. Signed-off-by: Antoine Tenart <[email protected]>
Reuse the same logic that is used elsewhere to parse probes, so the user has a unified experience. Also this allows using the same defaults and abbreviations. Signed-off-by: Antoine Tenart <[email protected]>
This should now be the default usage as it makes things easier. Explicit probe types can be used if not used by default (eg. kretprobe) or in profiles. Signed-off-by: Antoine Tenart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements in how we parse
--probecli arguments, to make them easier to use and more aligned to other tools with similar arguments.