Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1224] Update .stylelintrc.json to check for spacing #2094

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[#1224] Update .stylelintrc.json to check for spacing #2094

merged 3 commits into from
Jan 31, 2024

Conversation

sopa301
Copy link
Contributor

@sopa301 sopa301 commented Jan 22, 2024

Fixes #1224

Proposed commit message

Update .stylelintrc.json to Check for Spacing

With no current plans to update stylelint to v15 or beyond, we can
still use the current features to enforce consistent spacing in our
scss files. This will make the coding style more consistent throughout
the codebase.

Let's update the rules in .stylelintrc.json to enforce spacing.

Other information

Discussion on the upgrading of stylelint and the search for a replacement linter can be found in the mentioned issue.

@sopa301 sopa301 requested a review from a team January 22, 2024 19:07
jonasongg
jonasongg approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jonasongg jonasongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonasongg jonasongg requested a review from a team January 23, 2024 03:33
georgetayqy
georgetayqy approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@georgetayqy georgetayqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ckcherry23
ckcherry23 approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 requested a review from a team January 28, 2024 07:31
vvidday
vvidday approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckcherry23 ckcherry23 merged commit f5855fa into reposense:master Jan 31, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasongg jonasongg jonasongg approved these changes

@georgetayqy georgetayqy georgetayqy approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@vvidday vvidday vvidday approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement style check on spacing
5 participants
@sopa301 @vvidday @ckcherry23 @georgetayqy @jonasongg