-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1872] Update Node version to 18 #2081
Conversation
Closed because I don't have the required competencies (as of now) to properly fix the issue. Here are some things I learned in the process.
|
The following links are for previewing this pull request:
|
Thanks @sopa301 for your detailed investigation regarding the issue and reporting it here! |
…72-upgrade-node-18
c9e3c18
to
4e5c7ab
Compare
Co-authored-by: Charisma Kausar <[email protected]>
It's interesting to note #2102 somehow fixed the bug mentioned above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @sopa301, can you look into resolving the merge conflict?
@vvidday Updated! |
thanks! :) |
The following links are for previewing this pull request:
|
Fixes #1872
Proposed commit message
Other information
The update involved removing the depreciated node-sass.