Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1945] Enforce stricter formatting rules for TypeScript files #1957

Merged
merged 7 commits into from
Mar 25, 2023
Merged

[#1945] Enforce stricter formatting rules for TypeScript files #1957

merged 7 commits into from
Mar 25, 2023

Conversation

vvidday
Copy link
Contributor

@vvidday vvidday commented Mar 20, 2023 •
edited
Loading

Fixes #1945

Proposed commit message

Currently, our ESLint ruleset does not enforce certain formatting rules
for TypeScript code, such as delimiters in TypeScript interfaces and
spacing in type annotations.

Let's update the ESLint ruleset to check for proper delimiters and
spacing in type annotations. This will enforce consistency throughout
the codebase and improve code readability.

Other information

Most of the information is in #1945. The first rule enforces semicolons as delimiters in TypeScript interfaces, and the second rule enforces the following format for type annotations: foo: string over foo : string or foo :string.

@vvidday vvidday marked this pull request as ready for review March 20, 2023 05:22
@vvidday vvidday requested a review from a team March 20, 2023 05:22
ckcherry23
ckcherry23 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckcherry23 ckcherry23 requested a review from a team March 20, 2023 05:31
@HCY123902 HCY123902 requested a review from a team March 20, 2023 06:21
zhoukerrr
zhoukerrr approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@zhoukerrr zhoukerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcshzj dcshzj merged commit 34c2898 into reposense:master Mar 25, 2023
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@HCY123902 HCY123902 HCY123902 approved these changes

@zhoukerrr zhoukerrr zhoukerrr approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce stricter formatting rules for TypeScript files in ESLint
5 participants
@vvidday @zhoukerrr @HCY123902 @ckcherry23 @dcshzj