-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1936] Migrate app.vue to TypeScript #1938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on getting the TypeScript migration underway! I noticed that there are a few objects that could benefit from having explicit types as they are destructured later on. Left some comments to that effect.
…d set certain attributes in vuex.d.ts to be optional
… into migrate-typescript-app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following links are for previewing this pull request:
|
Part of #1936
Proposed commit message
Other information
The diff might look confusing because of the re-ordering of the options (apologies for missing this in #1867), please look at 4bfc3aa to see the actual diff of the TypeScript conversion.
I had to use
any
to define the app property ofwindow.app
- not too sure if it's possible to type this.Lastly, regarding the topic of combining/separating PRs, I was not too sure whether to separate this from #1937. Because of the nature of TypeScript migrations, the PRs would probably be mostly sequential (e.g. this PR relies on the previous PR for the
this.$store
to be typed), and hence also contains the changes of that PR. This might result in more work, such as requiring maintainers to merge a specific PR before another, as well as any changes to the preceding PR might have to be merged back into this one. I guess there's a tradeoff between the above and keeping the PR's to 'one small change'. Currently, I leaned towards separating them as each change is fairly substantial and they are two separate files. Would love to get any feedback/opinions on this.