EPMRPP-90249 roles refactor #1987

grabsefx · 2024-05-06T07:56:26Z

No description provided.

# Conflicts: # build.gradle # project-properties.gradle # src/main/java/com/epam/ta/reportportal/core/integration/impl/ExecuteIntegrationHandlerImpl.java # src/main/java/com/epam/ta/reportportal/core/project/GetProjectHandler.java # src/main/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImpl.java # src/main/java/com/epam/ta/reportportal/ws/controller/LaunchController.java # src/main/java/com/epam/ta/reportportal/ws/controller/PluginController.java # src/main/java/com/epam/ta/reportportal/ws/controller/ProjectController.java # src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-06T07:57:04Z

src/main/java/com/epam/ta/reportportal/ws/rabbit/AsyncReportingListener.java

@@ -222,8 +223,8 @@ public void onFinishItem(FinishTestItemRQ rq, String username, String projectNam
        extractProjectDetails(user, normalizeId(projectName)), itemId, rq);
  }

-	private ReportPortalUser.ProjectDetails extractProjectDetails(ReportPortalUser user, String projectName) {
-    return projectExtractor.extractProjectDetails(user, projectName);
+	private MembershipDetails extractProjectDetails(ReportPortalUser user, String projectName) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-06T07:57:04Z

src/main/java/com/epam/ta/reportportal/ws/rabbit/AsyncReportingListener.java

@@ -222,8 +223,8 @@
        extractProjectDetails(user, normalizeId(projectName)), itemId, rq);
  }

-	private ReportPortalUser.ProjectDetails extractProjectDetails(ReportPortalUser user, String projectName) {
-    return projectExtractor.extractProjectDetails(user, projectName);
+	private MembershipDetails extractProjectDetails(ReportPortalUser user, String projectName) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 8, expected level should be 2.

github-actions · 2024-05-06T07:57:04Z

src/main/java/com/epam/ta/reportportal/ws/controller/DashboardController.java

@@ -110,7 +110,7 @@ public OperationCompletionRS addWidget(@PathVariable String projectKey,
      @PathVariable Long dashboardId, @RequestBody @Validated AddWidgetRq addWidgetRq,
      @AuthenticationPrincipal ReportPortalUser user) {
    return updateDashboardHandler.addWidget(
-        dashboardId, projectExtractor.extractProjectDetails(user, projectKey), addWidgetRq, user);
+        dashboardId, projectExtractor.extractMembershipDetails(user, projectKey), addWidgetRq, user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 101).

github-actions · 2024-05-06T07:57:04Z

src/main/java/com/epam/ta/reportportal/ws/controller/ProjectController.java

@@ -265,7 +265,7 @@ public Iterable<UserResource> getUsersForAssign(@FilterFor(User.class) Filter fi
  public List<String> getProjectUsers(@PathVariable String projectKey,
      @RequestParam(value = FilterCriteriaResolver.DEFAULT_FILTER_PREFIX + Condition.CNT + "users")
      String value, @AuthenticationPrincipal ReportPortalUser user) {
-    return getProjectHandler.getUserNames(projectExtractor.extractProjectDetails(user, projectKey),
+    return getProjectHandler.getUserNames(projectExtractor.extractMembershipDetails(user, projectKey),


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

github-actions · 2024-05-06T07:57:05Z

src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java

@@ -24,6 +24,7 @@
 import com.epam.ta.reportportal.commons.querygen.Filter;
 import com.epam.ta.reportportal.core.activity.ActivityHandler;
 import com.epam.ta.reportportal.entity.activity.Activity;
+ import com.epam.ta.reportportal.entity.organization.MembershipDetails;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'import' has incorrect indentation level 1, expected level should be 0.

github-actions · 2024-05-06T07:57:06Z

src/main/java/com/epam/ta/reportportal/reporting/EventBasedReporting.java

+        startRootItemRqEvent.getStartTestItemRQ());
+  }
+
+  @EventListener


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-06T07:57:06Z

src/main/java/com/epam/ta/reportportal/reporting/EventBasedReporting.java

+        startChildItemRqEvent.getStartTestItemRQ(), startChildItemRqEvent.getParentUuid());
+  }
+
+  @EventListener


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-06T07:57:06Z

src/main/java/com/epam/ta/reportportal/reporting/EventBasedReporting.java

+        finishItemRqEvent.getFinishTestItemRQ());
+  }
+
+  @EventListener


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-06T07:57:06Z

src/main/java/com/epam/ta/reportportal/demodata/service/DemoDataService.java

@@ -39,16 +40,16 @@ public DemoDataService(DemoDashboardsService demoDashboardsService,
    this.demoDataFacade = demoDataFacade;
  }

-  public DemoDataRs generate(DemoDataRq demoDataRq, ReportPortalUser.ProjectDetails projectDetails,
+  public DemoDataRs generate(DemoDataRq demoDataRq, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-06T07:57:06Z

src/main/java/com/epam/ta/reportportal/demodata/service/DefaultDemoDataFacade.java


    demoLaunch.getSuites().forEach(suite -> {
      final SuiteGeneratorType suiteGeneratorType = SuiteGeneratorType.valueOf(suite.getType());
      final SuiteGenerator suiteGenerator = suiteGeneratorResolver.resolve(suiteGeneratorType);
-      suiteGenerator.generateSuites(suite, RootMetaData.of(launch.getUuid(), user, projectDetails));
+      suiteGenerator.generateSuites(suite, RootMetaData.of(launch.getUuid(), user, membershipDetails));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 103).

# Conflicts: # build.gradle # src/main/java/com/epam/ta/reportportal/ws/controller/ProjectController.java # src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-06T08:24:14Z

src/main/java/com/epam/ta/reportportal/model/project/email/SenderCaseDTO.java

-		return Objects.hash(recipients, sendCase, launchNames, attributes, enabled, attributesOperator);
-	}
+
+  /**


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> _{reported by reviewdog 🐶}
First sentence of Javadoc is missing an ending period.

github-actions · 2024-05-06T08:24:14Z

src/main/java/com/epam/ta/reportportal/model/project/email/SenderCaseDTO.java

+  public SenderCaseDTO() {
+  }
+
+  public SenderCaseDTO(Long id, String ruleName, List<String> recipients, String sendCase,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-06T08:24:14Z

src/main/java/com/epam/ta/reportportal/model/project/email/SenderCaseDTO.java

+  /* Auto generated methods */
+  @Override
+  public String toString() {
+    return "SenderCaseDTO{" +


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck> _{reported by reviewdog 🐶}
'+' should be on a new line.

github-actions · 2024-05-06T08:24:14Z

src/main/java/com/epam/ta/reportportal/model/project/email/SenderCaseDTO.java

+  @Override
+  public String toString() {
+    return "SenderCaseDTO{" +
+        "id=" + id +


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck> _{reported by reviewdog 🐶}
'+' should be on a new line.

github-actions · 2024-05-06T08:24:14Z

src/main/java/com/epam/ta/reportportal/model/project/email/SenderCaseDTO.java

+  public String toString() {
+    return "SenderCaseDTO{" +
+        "id=" + id +
+        ", ruleName='" + ruleName + '\'' +


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck> _{reported by reviewdog 🐶}
'+' should be on a new line.

github-actions · 2024-05-06T08:24:16Z

...m/ta/reportportal/core/item/impl/history/provider/impl/ComparingBaselineHistoryProvider.java

 					));

-			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(projectDetails,
+			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-06T08:24:16Z

...m/ta/reportportal/core/item/impl/history/provider/impl/ComparingBaselineHistoryProvider.java

 					));

-			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(projectDetails,
+			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'block' child has incorrect indentation level 24, expected level should be 18.

github-actions · 2024-05-06T08:24:16Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

@@ -61,23 +62,23 @@ public FilterBaselineHistoryProvider(LaunchRepository launchRepository, LaunchAc

 	@Override
 	public Page<TestItemHistory> provide(Queryable filter, Pageable pageable, HistoryRequestParams historyRequestParams,
-			ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user, boolean usingHash) {
+			MembershipDetails membershipDetails, ReportPortalUser user, boolean usingHash) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 104).

github-actions · 2024-05-06T08:24:16Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

@@ -61,23 +62,23 @@

 	@Override
 	public Page<TestItemHistory> provide(Queryable filter, Pageable pageable, HistoryRequestParams historyRequestParams,
-			ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user, boolean usingHash) {
+			MembershipDetails membershipDetails, ReportPortalUser user, boolean usingHash) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-06T08:24:16Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

 		return historyRequestParams.getFilterParams().map(filterParams -> {

-			UserFilter userFilter = filterRepository.findByIdAndProjectId(filterParams.getFilterId(), projectDetails.getProjectId())
+			UserFilter userFilter = filterRepository.findByIdAndProjectId(filterParams.getFilterId(), membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 147).

# Conflicts: # build.gradle # src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-06T11:25:17Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

 		return historyRequestParams.getFilterParams().map(filterParams -> {

-			UserFilter userFilter = filterRepository.findByIdAndProjectId(filterParams.getFilterId(), projectDetails.getProjectId())
+			UserFilter userFilter = filterRepository.findByIdAndProjectId(filterParams.getFilterId(), membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-06T11:25:17Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

 		return historyRequestParams.getFilterParams().map(filterParams -> {

-			UserFilter userFilter = filterRepository.findByIdAndProjectId(filterParams.getFilterId(), projectDetails.getProjectId())
+			UserFilter userFilter = filterRepository.findByIdAndProjectId(filterParams.getFilterId(), membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'block' child has incorrect indentation level 24, expected level should be 18.

github-actions · 2024-05-06T11:25:17Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

 					.orElseThrow(() -> new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT,
 							filterParams.getFilterId(),
-							projectDetails.getProjectName()
+              membershipDetails.getProjectName()


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'membershipDetails' has incorrect indentation level 14, expected level should be 28.

github-actions · 2024-05-06T11:25:17Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

 					));

-			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(projectDetails,
+			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 151).

github-actions · 2024-05-06T11:25:18Z

...epam/ta/reportportal/core/item/impl/history/provider/impl/FilterBaselineHistoryProvider.java

 					));

-			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(projectDetails,
+			Pair<Queryable, Pageable> launchQueryablePair = DefaultLaunchFilterProvider.createDefaultLaunchQueryablePair(membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-06T11:25:19Z

...n/java/com/epam/ta/reportportal/core/item/impl/provider/impl/BaselineLaunchDataProvider.java

      ReportPortalUser user, Map<String, String> params) {
-    final Queryable targetFilter = getLaunchIdFilter(LAUNCH_ID_PARAM, params, projectDetails, user);
+    final Queryable targetFilter = getLaunchIdFilter(LAUNCH_ID_PARAM, params, membershipDetails, user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 103).

github-actions · 2024-05-06T11:25:19Z

...n/java/com/epam/ta/reportportal/core/item/impl/provider/impl/BaselineLaunchDataProvider.java

      Map<String, String> params) {
-    final Queryable targetFilter = getLaunchIdFilter(LAUNCH_ID_PARAM, params, projectDetails, user);
+    final Queryable targetFilter = getLaunchIdFilter(LAUNCH_ID_PARAM, params, membershipDetails, user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 103).

github-actions · 2024-05-06T11:25:19Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

@@ -59,29 +60,29 @@ public class MaterializedWidgetProviderHandlerImpl implements DataProviderHandle
 	private WidgetRepository widgetRepository;

 	@Override
-	public Page<TestItem> getTestItems(Queryable filter, Pageable pageable, ReportPortalUser.ProjectDetails projectDetails,
+	public Page<TestItem> getTestItems(Queryable filter, Pageable pageable, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 116).

github-actions · 2024-05-06T11:25:19Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

@@ -59,29 +60,29 @@
 	private WidgetRepository widgetRepository;

 	@Override
-	public Page<TestItem> getTestItems(Queryable filter, Pageable pageable, ReportPortalUser.ProjectDetails projectDetails,
+	public Page<TestItem> getTestItems(Queryable filter, Pageable pageable, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-06T11:25:19Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

 			ReportPortalUser user, Map<String, String> providerParams) {
-		WidgetType widgetType = updateProviderParams(projectDetails, providerParams);
-		return testItemWidgetDataProviders.get(widgetType).getTestItems(filter, pageable, projectDetails, user, providerParams);
+		WidgetType widgetType = updateProviderParams(membershipDetails, providerParams);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-07T07:25:13Z

src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java

         projectExtractor.extractProjectDetailsAdmin(user, EntityUtils.normalizeId(projectKey));
-     return activityHandler.getActivity(projectDetails, activityId);
+     return activityHandler.getActivity(membershipDetails, activityId);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def' child has incorrect indentation level 5, expected level should be 4.

github-actions · 2024-05-07T07:25:13Z

src/main/java/com/epam/ta/reportportal/auth/permissions/BaseProjectPermission.java


-    ProjectRole role = projectDetails.getProjectRole();
-    return checkAllowed(rpUser, projectKey.toString(), role);
+    return checkAllowed(rpUser, projectKey.toString(), membershipDetails.getOrgRole(), membershipDetails.getProjectRole());


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 123).

github-actions · 2024-05-07T07:25:14Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

 			ReportPortalUser user, Map<String, String> providerParams) {
-		WidgetType widgetType = updateProviderParams(projectDetails, providerParams);
-		return testItemWidgetDataProviders.get(widgetType).getTestItems(filter, pageable, projectDetails, user, providerParams);
+		WidgetType widgetType = updateProviderParams(membershipDetails, providerParams);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def' child has incorrect indentation level 16, expected level should be 4.

github-actions · 2024-05-07T07:25:14Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

-		WidgetType widgetType = updateProviderParams(projectDetails, providerParams);
-		return testItemWidgetDataProviders.get(widgetType).getTestItems(filter, pageable, projectDetails, user, providerParams);
+		WidgetType widgetType = updateProviderParams(membershipDetails, providerParams);
+		return testItemWidgetDataProviders.get(widgetType).getTestItems(filter, pageable, membershipDetails, user, providerParams);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 139).

github-actions · 2024-05-07T07:25:14Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

-		WidgetType widgetType = updateProviderParams(projectDetails, providerParams);
-		return testItemWidgetDataProviders.get(widgetType).getTestItems(filter, pageable, projectDetails, user, providerParams);
+		WidgetType widgetType = updateProviderParams(membershipDetails, providerParams);
+		return testItemWidgetDataProviders.get(widgetType).getTestItems(filter, pageable, membershipDetails, user, providerParams);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-07T07:25:15Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

 	}

-	private WidgetType updateProviderParams(ReportPortalUser.ProjectDetails projectDetails, Map<String, String> providerParams) {
+	private WidgetType updateProviderParams(MembershipDetails membershipDetails, Map<String, String> providerParams) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 8, expected level should be 2.

github-actions · 2024-05-07T07:25:15Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

 		Long widgetId = Optional.ofNullable(providerParams.get(WIDGET_ID_PARAM))
 				.map(ControllerUtils::safeParseLong)
 				.orElseThrow(() -> new ReportPortalException(ErrorType.BAD_REQUEST_ERROR,
 						"Widget id must be provided for widget based items provider"
 				));
-		Widget widget = widgetRepository.findByIdAndProjectId(widgetId, projectDetails.getProjectId())
+		Widget widget = widgetRepository.findByIdAndProjectId(widgetId, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 113).

github-actions · 2024-05-07T07:25:15Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

 		Long widgetId = Optional.ofNullable(providerParams.get(WIDGET_ID_PARAM))
 				.map(ControllerUtils::safeParseLong)
 				.orElseThrow(() -> new ReportPortalException(ErrorType.BAD_REQUEST_ERROR,
 						"Widget id must be provided for widget based items provider"
 				));
-		Widget widget = widgetRepository.findByIdAndProjectId(widgetId, projectDetails.getProjectId())
+		Widget widget = widgetRepository.findByIdAndProjectId(widgetId, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-07T07:25:15Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

 		Long widgetId = Optional.ofNullable(providerParams.get(WIDGET_ID_PARAM))
 				.map(ControllerUtils::safeParseLong)
 				.orElseThrow(() -> new ReportPortalException(ErrorType.BAD_REQUEST_ERROR,
 						"Widget id must be provided for widget based items provider"
 				));
-		Widget widget = widgetRepository.findByIdAndProjectId(widgetId, projectDetails.getProjectId())
+		Widget widget = widgetRepository.findByIdAndProjectId(widgetId, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def' child has incorrect indentation level 16, expected level should be 4.

github-actions · 2024-05-07T07:25:15Z

...epam/ta/reportportal/core/item/impl/provider/impl/MaterializedWidgetProviderHandlerImpl.java

 				.orElseThrow(() -> new ReportPortalException(ErrorType.WIDGET_NOT_FOUND_IN_PROJECT,
 						widgetId,
-						projectDetails.getProjectName()
+            membershipDetails.getProjectName()


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'membershipDetails' has incorrect indentation level 12, expected level should be 20.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-09T09:01:20Z

src/main/java/com/epam/ta/reportportal/ws/controller/LogAsyncController.java

@@ -17,7 +17,7 @@
 package com.epam.ta.reportportal.ws.controller;

 import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_REPORT;
-import static com.epam.ta.reportportal.auth.permissions.Permissions.ASSIGNED_TO_PROJECT;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Wrong lexicographical order for 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT' import. Should be before 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_REPORT'.

github-actions · 2024-05-09T09:01:20Z

src/main/java/com/epam/ta/reportportal/ws/controller/TestItemAsyncController.java

@@ -17,7 +17,7 @@
 package com.epam.ta.reportportal.ws.controller;

 import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_REPORT;
-import static com.epam.ta.reportportal.auth.permissions.Permissions.ASSIGNED_TO_PROJECT;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Wrong lexicographical order for 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT' import. Should be before 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_REPORT'.

github-actions · 2024-05-09T09:01:21Z

src/main/java/com/epam/ta/reportportal/ws/controller/PluginController.java

 import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_REPORT;
-import static com.epam.ta.reportportal.auth.permissions.Permissions.ASSIGNED_TO_PROJECT;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Wrong lexicographical order for 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT' import. Should be before 'com.epam.ta.reportportal.auth.permissions.Permissions.IS_ADMIN'.

github-actions · 2024-05-09T09:01:21Z

src/main/java/com/epam/ta/reportportal/ws/controller/IntegrationController.java

-import static com.epam.ta.reportportal.auth.permissions.Permissions.ADMIN_ONLY;
-import static com.epam.ta.reportportal.auth.permissions.Permissions.ASSIGNED_TO_PROJECT;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.IS_ADMIN;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Wrong lexicographical order for 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT' import. Should be before 'com.epam.ta.reportportal.auth.permissions.Permissions.IS_ADMIN'.

github-actions · 2024-05-09T09:01:21Z

src/main/java/com/epam/ta/reportportal/ws/controller/LogController.java

@@ -17,7 +17,7 @@
 package com.epam.ta.reportportal.ws.controller;

 import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_REPORT;
-import static com.epam.ta.reportportal.auth.permissions.Permissions.ASSIGNED_TO_PROJECT;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Wrong lexicographical order for 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT' import. Should be before 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_REPORT'.

github-actions · 2024-05-09T09:01:23Z

src/main/java/com/epam/ta/reportportal/core/item/impl/FinishTestItemHandlerImpl.java

      Launch launch) {
    if (user.getUserRole() != UserRole.ADMINISTRATOR) {
-      expect(launch.getProjectId(), equalTo(projectDetails.getProjectId())).verify(ACCESS_DENIED);
-      if (!launch.isRerun() && projectDetails.getProjectRole().lowerThan(PROJECT_MANAGER)) {
+      expect(launch.getProjectId(), equalTo(membershipDetails.getProjectId())).verify(ACCESS_DENIED);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 101).

github-actions · 2024-05-09T09:01:23Z

src/main/java/com/epam/ta/reportportal/core/item/impl/FinishTestItemHandlerImpl.java

+
+      if (!launch.isRerun()
+          // TODO revert equals to avoid nullpointers
+          && (membershipDetails.getOrgRole().lowerThan(OrganizationRole.MANAGER) && membershipDetails.getProjectRole().equals(ProjectRole.VIEWER))) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 149).

github-actions · 2024-05-09T09:01:23Z

src/main/java/com/epam/ta/reportportal/core/analyzer/strategy/LaunchAutoAnalysisStrategy.java

@@ -54,7 +55,7 @@ public LaunchAutoAnalysisStrategy(ProjectRepository projectRepository,
    this.manualAnalysisStarter = manualAnalysisStarter;
  }

-  public void analyze(AnalyzeLaunchRQ analyzeRQ, ReportPortalUser.ProjectDetails projectDetails,
+  public void analyze(AnalyzeLaunchRQ analyzeRQ, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-09T09:01:23Z

src/main/java/com/epam/ta/reportportal/core/analyzer/strategy/LaunchAutoAnalysisStrategy.java

@@ -54,7 +55,7 @@
    this.manualAnalysisStarter = manualAnalysisStarter;
  }

-  public void analyze(AnalyzeLaunchRQ analyzeRQ, ReportPortalUser.ProjectDetails projectDetails,
+  public void analyze(AnalyzeLaunchRQ analyzeRQ, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> _{reported by reviewdog 🐶}
Abbreviation in name 'analyzeRQ' must contain no more than '1' consecutive capital letters.

github-actions · 2024-05-09T09:01:23Z

...main/java/com/epam/ta/reportportal/core/analyzer/strategy/LaunchPatternAnalysisStrategy.java

@@ -49,7 +50,7 @@ public LaunchPatternAnalysisStrategy(ProjectRepository projectRepository,
    this.launchPatternAnalyzer = launchPatternAnalyzer;
  }

-  public void analyze(AnalyzeLaunchRQ analyzeRQ, ReportPortalUser.ProjectDetails projectDetails,
+  public void analyze(AnalyzeLaunchRQ analyzeRQ, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-09T13:51:08Z

src/main/java/com/epam/ta/reportportal/auth/permissions/AllowedToViewProjectPermission.java

+import org.springframework.security.oauth2.provider.OAuth2Authentication;
+import org.springframework.stereotype.Component;
+
+/**


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> _{reported by reviewdog 🐶}
First sentence of Javadoc is missing an ending period.

github-actions · 2024-05-09T13:51:09Z

src/main/java/com/epam/ta/reportportal/auth/permissions/AllowedToEditProjectPermission.java

+
+    var md = membershipDetails.get();
+    if (OrganizationRole.MANAGER == md.getOrgRole() || ProjectRole.EDITOR == md.getProjectRole()) {
+      membershipDetails.ifPresent(details -> fillProjectDetails(rpUser, resolvedProjectKey, details));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

github-actions · 2024-05-09T13:51:09Z

...main/java/com/epam/ta/reportportal/core/analyzer/strategy/LaunchPatternAnalysisStrategy.java

@@ -49,7 +50,7 @@ public LaunchPatternAnalysisStrategy(ProjectRepository projectRepository,
    this.launchPatternAnalyzer = launchPatternAnalyzer;
  }

-  public void analyze(AnalyzeLaunchRQ analyzeRQ, ReportPortalUser.ProjectDetails projectDetails,
+  public void analyze(AnalyzeLaunchRQ analyzeRQ, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> _{reported by reviewdog 🐶}
Abbreviation in name 'analyzeRQ' must contain no more than '1' consecutive capital letters.

github-actions · 2024-05-09T13:51:09Z

src/main/java/com/epam/ta/reportportal/core/activity/impl/ActivityHandlerImpl.java

@@ -82,14 +83,14 @@ public ActivityHandlerImpl(ActivityRepository activityRepository, TestItemReposi
 	}

 	@Override
-	public Iterable<ActivityResource> getActivitiesHistory(ReportPortalUser.ProjectDetails projectDetails, Filter filter,
+	public Iterable<ActivityResource> getActivitiesHistory(MembershipDetails membershipDetails, Filter filter,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 114).

github-actions · 2024-05-09T13:51:09Z

src/main/java/com/epam/ta/reportportal/core/activity/impl/ActivityHandlerImpl.java

@@ -82,14 +83,14 @@
 	}

 	@Override
-	public Iterable<ActivityResource> getActivitiesHistory(ReportPortalUser.ProjectDetails projectDetails, Filter filter,
+	public Iterable<ActivityResource> getActivitiesHistory(MembershipDetails membershipDetails, Filter filter,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-09T13:51:10Z

src/main/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImpl.java

@@ -296,12 +297,12 @@ public List<String> getOwners(ReportPortalUser.ProjectDetails projectDetails, St
            formattedSupplier("Mode - {} doesn't exist.", mode)
        ));

-    return launchRepository.getOwnerNames(projectDetails.getProjectId(), value, launchMode.name());
+    return launchRepository.getOwnerNames(membershipDetails.getProjectId(), value, launchMode.name());


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

github-actions · 2024-05-09T13:51:11Z

src/main/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImpl.java

@@ -313,7 +314,7 @@
        new FilterCondition(Condition.IN, false,
            Arrays.stream(ids).map(String::valueOf).collect(Collectors.joining(",")), CRITERIA_ID
        )).withCondition(
-        new FilterCondition(EQUALS, false, String.valueOf(projectDetails.getProjectId()),
+        new FilterCondition(EQUALS, false, String.valueOf(membershipDetails.getProjectId()),


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'new' has incorrect indentation level 8, expected level should be one of the following: 10, 12.

github-actions · 2024-05-09T13:51:11Z

src/main/java/com/epam/ta/reportportal/core/launch/impl/MergeLaunchHandlerImpl.java

      ReportPortalUser user, MergeLaunchesRQ rq) {
-    Project project = projectRepository.findById(projectDetails.getProjectId()).orElseThrow(
-        () -> new ReportPortalException(PROJECT_NOT_FOUND, projectDetails.getProjectName()));
+    Project project = projectRepository.findById(membershipDetails.getProjectId()).orElseThrow(


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck> _{reported by reviewdog 🐶}
Distance between variable 'project' declaration and its first usage is 8, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).

github-actions · 2024-05-09T13:51:11Z

src/main/java/com/epam/ta/reportportal/core/launch/impl/DeleteLaunchHandlerImpl.java

          )
      );
      /* Only PROJECT_MANAGER roles could delete launches */
-      if (projectDetails.getProjectRole().lowerThan(PROJECT_MANAGER)) {
-        expect(user.getUserId(), Predicate.isEqual(launch.getUserId())).verify(ACCESS_DENIED,
+      if ((membershipDetails.getOrgRole().lowerThan(OrganizationRole.MANAGER) && membershipDetails.getProjectRole().equals(ProjectRole.VIEWER))) {


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 146).

github-actions · 2024-05-09T13:51:11Z

src/main/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImpl.java

-    expect(getProjectHandler.exists(projectDetails.getProjectId()), Predicate.isEqual(true)).verify(
-        PROJECT_NOT_FOUND, projectDetails.getProjectId());
+      MembershipDetails membershipDetails) {
+    expect(getProjectHandler.exists(membershipDetails.getProjectId()), Predicate.isEqual(true)).verify(


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 103).

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-10T11:42:01Z

src/main/java/com/epam/ta/reportportal/ws/controller/TestItemController.java

-import static com.epam.ta.reportportal.auth.permissions.Permissions.PROJECT_MANAGER_OR_ADMIN;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT;
+
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_VIEW_PROJECT;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Extra separation in import group before 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_VIEW_PROJECT'

github-actions · 2024-05-10T11:42:02Z

src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java

@@ -48,7 +49,7 @@
 @RestController
 @RequestMapping("/v1/{projectKey}/activity")
 @Transactional(readOnly = true)
- @PreAuthorize(ASSIGNED_TO_PROJECT)
+ @PreAuthorize(ALLOWED_TO_VIEW_PROJECT)


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'class def modifier' has incorrect indentation level 1, expected level should be 0.

github-actions · 2024-05-10T11:42:02Z

src/main/java/com/epam/ta/reportportal/ws/controller/ActivityController.java

@@ -67,9 +68,9 @@
   @Operation(summary =  "Get activity by id")
   public ActivityResource getActivity(@PathVariable String projectKey,
       @PathVariable Long activityId, @AuthenticationPrincipal ReportPortalUser user) {
-     ReportPortalUser.ProjectDetails projectDetails =
+     MembershipDetails membershipDetails =


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def' child has incorrect indentation level 5, expected level should be 4.

github-actions · 2024-05-10T11:42:02Z

src/main/java/com/epam/ta/reportportal/ws/controller/PluginController.java

-import static com.epam.ta.reportportal.auth.permissions.Permissions.ASSIGNED_TO_PROJECT;
+import static com.epam.ta.reportportal.auth.permissions.Permissions.IS_ADMIN;
+
+import static com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT;


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> _{reported by reviewdog 🐶}
Extra separation in import group before 'com.epam.ta.reportportal.auth.permissions.Permissions.ALLOWED_TO_EDIT_PROJECT'

github-actions · 2024-05-10T11:42:02Z

src/main/java/com/epam/ta/reportportal/ws/controller/PluginController.java

        executionParams
    );
  }

-  @PreAuthorize(ALLOWED_TO_REPORT)
-  @PostMapping(value = "/{projectName}/{pluginName}/import", consumes = {
+  @PreAuthorize(ALLOWED_TO_EDIT_PROJECT)


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-10T11:42:04Z

src/main/java/com/epam/ta/reportportal/core/preference/impl/UpdatePreferenceHandlerImpl.java


-		if (userPreferenceRepository.findByProjectIdAndUserIdAndFilterId(projectDetails.getProjectId(), user.getUserId(), filterId)
+		if (userPreferenceRepository.findByProjectIdAndUserIdAndFilterId(membershipDetails.getProjectId(), user.getUserId(), filterId)


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'if' has incorrect indentation level 16, expected level should be 4.

github-actions · 2024-05-10T11:42:04Z

src/main/java/com/epam/ta/reportportal/core/preference/impl/UpdatePreferenceHandlerImpl.java

 				.isPresent()) {
 			throw new ReportPortalException(ErrorType.RESOURCE_ALREADY_EXISTS, "User Preference");
 		}

-		UserFilter filter = userFilterRepository.findByIdAndProjectId(filterId, projectDetails.getProjectId())
+		UserFilter filter = userFilterRepository.findByIdAndProjectId(filterId, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 121).

github-actions · 2024-05-10T11:42:04Z

src/main/java/com/epam/ta/reportportal/core/preference/impl/UpdatePreferenceHandlerImpl.java

 				.isPresent()) {
 			throw new ReportPortalException(ErrorType.RESOURCE_ALREADY_EXISTS, "User Preference");
 		}

-		UserFilter filter = userFilterRepository.findByIdAndProjectId(filterId, projectDetails.getProjectId())
+		UserFilter filter = userFilterRepository.findByIdAndProjectId(filterId, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-10T11:42:04Z

src/main/java/com/epam/ta/reportportal/core/preference/impl/UpdatePreferenceHandlerImpl.java

 				.isPresent()) {
 			throw new ReportPortalException(ErrorType.RESOURCE_ALREADY_EXISTS, "User Preference");
 		}

-		UserFilter filter = userFilterRepository.findByIdAndProjectId(filterId, projectDetails.getProjectId())
+		UserFilter filter = userFilterRepository.findByIdAndProjectId(filterId, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def' child has incorrect indentation level 16, expected level should be 4.

github-actions · 2024-05-10T11:42:04Z

src/main/java/com/epam/ta/reportportal/core/preference/impl/UpdatePreferenceHandlerImpl.java

 				.orElseThrow(() -> new ReportPortalException(ErrorType.USER_FILTER_NOT_FOUND_IN_PROJECT,
 						filterId,
-						projectDetails.getProjectName()
+            membershipDetails.getProjectName()


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'membershipDetails' has incorrect indentation level 12, expected level should be 20.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-13T07:41:03Z

src/main/java/com/epam/ta/reportportal/ws/controller/UserController.java

@@ -132,7 +132,7 @@ public CreateUserRS createUserByAdmin(@RequestBody @Validated CreateUserRQFull r
  @Transactional
  @PostMapping(value = "/bid")
  @ResponseStatus(CREATED)
-  @PreAuthorize("(hasPermission(#createUserRQ.getDefaultProject(), 'projectManagerPermission')) || hasRole('ADMINISTRATOR')")
+  @PreAuthorize("(hasPermission(#createUserRQ.getDefaultProject(), 'allowedToEditProject')) || hasRole('ADMINISTRATOR')")


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 121).

github-actions · 2024-05-13T07:41:03Z

src/main/java/com/epam/ta/reportportal/auth/permissions/AllowedToViewProjectPermission.java

+    this.projectExtractor = projectExtractor;
+  }
+
+  /**


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> _{reported by reviewdog 🐶}
First sentence of Javadoc is missing an ending period.

github-actions · 2024-05-13T07:41:03Z

src/main/java/com/epam/ta/reportportal/auth/permissions/AllowedToViewProjectPermission.java

+
+    var md = membershipDetails.get();
+    if (OrganizationRole.MANAGER == md.getOrgRole() || md.getProjectRole() != null) {
+      membershipDetails.ifPresent(details -> fillProjectDetails(rpUser, resolvedProjectKey, details));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

github-actions · 2024-05-13T07:41:03Z

src/main/java/com/epam/ta/reportportal/auth/permissions/OrganizationManagerPermission.java

+import org.springframework.security.oauth2.provider.OAuth2Authentication;
+import org.springframework.stereotype.Component;
+
+@Component("organizationManagerPermission")


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

github-actions · 2024-05-13T07:41:03Z

src/main/java/com/epam/ta/reportportal/auth/permissions/OrganizationManagerPermission.java

+
+    var md = membershipDetails.get();
+    if (OrganizationRole.MANAGER == md.getOrgRole()) {
+      membershipDetails.ifPresent(details -> fillProjectDetails(rpUser, resolvedProjectKey, details));


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 102).

github-actions · 2024-05-13T07:41:05Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param user           User
 	 * @return WidgetResource
 	 */
-	WidgetResource getWidget(Long widgetId, ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user);
+	WidgetResource getWidget(Long widgetId, MembershipDetails membershipDetails, ReportPortalUser user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 108).

github-actions · 2024-05-13T07:41:05Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param user           User
 	 * @return WidgetResource
 	 */
-	WidgetResource getWidget(Long widgetId, ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user);
+	WidgetResource getWidget(Long widgetId, MembershipDetails membershipDetails, ReportPortalUser user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-13T07:41:05Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param user           User
 	 * @return WidgetResource
 	 */
-	WidgetResource getWidget(Long widgetId, ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user);
+	WidgetResource getWidget(Long widgetId, MembershipDetails membershipDetails, ReportPortalUser user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 8, expected level should be 2.

github-actions · 2024-05-13T07:41:05Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param attributes     Attributes
 	 * @param params         Additional widget params
 	 * @param user           User
 	 * @return WidgetResource
 	 */
-	WidgetResource getWidget(Long widgetId, String[] attributes, MultiValueMap<String, String> params, ReportPortalUser.ProjectDetails projectDetails,
+	WidgetResource getWidget(Long widgetId, String[] attributes, MultiValueMap<String, String> params, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 143).

github-actions · 2024-05-13T07:41:05Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param attributes     Attributes
 	 * @param params         Additional widget params
 	 * @param user           User
 	 * @return WidgetResource
 	 */
-	WidgetResource getWidget(Long widgetId, String[] attributes, MultiValueMap<String, String> params, ReportPortalUser.ProjectDetails projectDetails,
+	WidgetResource getWidget(Long widgetId, String[] attributes, MultiValueMap<String, String> params, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

…ecification

# Conflicts: # build.gradle

# Conflicts: # build.gradle # project-properties.gradle # src/main/java/com/epam/ta/reportportal/core/launch/impl/StartLaunchHandlerImpl.java # src/test/java/com/epam/ta/reportportal/core/launch/impl/StartLaunchHandlerImplTest.java # src/test/resources/db/migration/V001004__add_organizations.sql

# Conflicts: # build.gradle # project-properties.gradle # src/test/resources/db/migration/V001004__add_organizations.sql

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

github-actions · 2024-05-15T09:55:47Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param attributes     Attributes
 	 * @param params         Additional widget params
 	 * @param user           User
 	 * @return WidgetResource
 	 */
-	WidgetResource getWidget(Long widgetId, String[] attributes, MultiValueMap<String, String> params, ReportPortalUser.ProjectDetails projectDetails,
+	WidgetResource getWidget(Long widgetId, String[] attributes, MultiValueMap<String, String> params, MembershipDetails membershipDetails,


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 8, expected level should be 2.

github-actions · 2024-05-15T09:55:47Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 			ReportPortalUser user);

 	/**
 	 * Get content for building preview while creating widget
 	 *
 	 * @param previewRQ      Widget parameters
-	 * @param projectDetails Project name
+	 * @param membershipDetails Membership details


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-15T09:55:47Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param user           Username
 	 * @return Widget content
 	 */
-	Map<String, ?> getWidgetPreview(WidgetPreviewRQ previewRQ, ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user);
+	Map<String, ?> getWidgetPreview(WidgetPreviewRQ previewRQ, MembershipDetails membershipDetails, ReportPortalUser user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 127).

github-actions · 2024-05-15T09:55:47Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param user           Username
 	 * @return Widget content
 	 */
-	Map<String, ?> getWidgetPreview(WidgetPreviewRQ previewRQ, ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user);
+	Map<String, ?> getWidgetPreview(WidgetPreviewRQ previewRQ, MembershipDetails membershipDetails, ReportPortalUser user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-15T09:55:47Z

src/main/java/com/epam/ta/reportportal/core/widget/GetWidgetHandler.java

 	 * @param user           Username
 	 * @return Widget content
 	 */
-	Map<String, ?> getWidgetPreview(WidgetPreviewRQ previewRQ, ReportPortalUser.ProjectDetails projectDetails, ReportPortalUser user);
+	Map<String, ?> getWidgetPreview(WidgetPreviewRQ previewRQ, MembershipDetails membershipDetails, ReportPortalUser user);


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def modifier' has incorrect indentation level 8, expected level should be 2.

github-actions · 2024-05-15T09:55:49Z

src/main/java/com/epam/ta/reportportal/core/dashboard/impl/GetDashboardHandlerImpl.java

-	public DashboardResource getDashboard(Long id, ReportPortalUser.ProjectDetails projectDetails) {
-		final Dashboard dashboard = dashboardRepository.findByIdAndProjectId(id, projectDetails.getProjectId())
+	public DashboardResource getDashboard(Long id, MembershipDetails membershipDetails) {
+		final Dashboard dashboard = dashboardRepository.findByIdAndProjectId(id, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 122).

github-actions · 2024-05-15T09:55:49Z

src/main/java/com/epam/ta/reportportal/core/dashboard/impl/GetDashboardHandlerImpl.java

-	public DashboardResource getDashboard(Long id, ReportPortalUser.ProjectDetails projectDetails) {
-		final Dashboard dashboard = dashboardRepository.findByIdAndProjectId(id, projectDetails.getProjectId())
+	public DashboardResource getDashboard(Long id, MembershipDetails membershipDetails) {
+		final Dashboard dashboard = dashboardRepository.findByIdAndProjectId(id, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> _{reported by reviewdog 🐶}
Line contains a tab character.

github-actions · 2024-05-15T09:55:49Z

src/main/java/com/epam/ta/reportportal/core/dashboard/impl/GetDashboardHandlerImpl.java

-	public DashboardResource getDashboard(Long id, ReportPortalUser.ProjectDetails projectDetails) {
-		final Dashboard dashboard = dashboardRepository.findByIdAndProjectId(id, projectDetails.getProjectId())
+	public DashboardResource getDashboard(Long id, MembershipDetails membershipDetails) {
+		final Dashboard dashboard = dashboardRepository.findByIdAndProjectId(id, membershipDetails.getProjectId())


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'method def' child has incorrect indentation level 16, expected level should be 4.

github-actions · 2024-05-15T09:55:49Z

src/main/java/com/epam/ta/reportportal/core/dashboard/impl/GetDashboardHandlerImpl.java

 				.orElseThrow(() -> new ReportPortalException(ErrorType.DASHBOARD_NOT_FOUND_IN_PROJECT,
 						id,
-						projectDetails.getProjectName()
+            membershipDetails.getProjectName()


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> _{reported by reviewdog 🐶}
'membershipDetails' has incorrect indentation level 12, expected level should be 20.

github-actions · 2024-05-15T09:55:49Z

src/main/java/com/epam/ta/reportportal/core/dashboard/impl/CreateDashboardHandlerImpl.java

      CreateDashboardRQ rq, ReportPortalUser user) {

-    BusinessRule.expect(dashboardRepository.findAllByProjectId(projectDetails.getProjectId()).size()
+    BusinessRule.expect(dashboardRepository.findAllByProjectId(membershipDetails.getProjectId()).size()


⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 100 characters (found 103).

grabsefx added 3 commits May 3, 2024 10:01

EPMRPP-90249 roles and permissions refactoring

03c38cf

EPMRPP-90249 roles and permissions refactoring

b5f7b78

grabsefx added the Do not merge label May 6, 2024

grabsefx self-assigned this May 6, 2024

github-actions bot reviewed May 6, 2024

View reviewed changes

Merge branch 'refs/heads/feature/orgs' into EPMRPP-90249-roles-refactor

52644e2

# Conflicts: # build.gradle # src/main/java/com/epam/ta/reportportal/ws/controller/ProjectController.java # src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java

github-actions bot reviewed May 6, 2024

View reviewed changes

Merge branch 'refs/heads/feature/orgs' into EPMRPP-90249-roles-refactor

b1f0b5a

# Conflicts: # build.gradle # src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java

github-actions bot reviewed May 6, 2024

View reviewed changes

reportportal deleted a comment from github-actions bot May 6, 2024

reportportal deleted a comment from github-actions bot May 7, 2024

EPMRPP-90249 role migration

9210543

github-actions bot reviewed May 7, 2024

View reviewed changes

reportportal deleted a comment from github-actions bot May 7, 2024

EPMRPP-90249 role migration

5039611

github-actions bot reviewed May 9, 2024

View reviewed changes

EPMRPP-90249 role migration

ef79a79

github-actions bot reviewed May 9, 2024

View reviewed changes

reportportal deleted a comment from github-actions bot May 10, 2024

EPMRPP-90249 role migration

6cbb1ad

github-actions bot reviewed May 10, 2024

View reviewed changes

reportportal deleted a comment from github-actions bot May 12, 2024

EPMRPP-90249 role migration

2721fb7

github-actions bot reviewed May 13, 2024

View reviewed changes

grabsefx removed the Do not merge label May 13, 2024

grabsefx marked this pull request as ready for review May 13, 2024 07:44

grabsefx requested a review from avarabyeu as a code owner May 13, 2024 07:44

grabsefx requested review from APiankouski, IvanKustau and pbortnik May 13, 2024 07:45

grabsefx added 9 commits May 13, 2024 20:12

EPMRPP-90160 Update organization-controller in accordance with API sp…

8fe4b0c

…ecification

EPMRPP-90160 Update organization-controller in accordance with API sp…

350f682

…ecification

EPMRPP-90160 Update organization-controller in accordance with API sp…

423061a

…ecification

Merge branch 'refs/heads/feature/orgs' into EPMRPP-90160

e262b05

Merge branch 'refs/heads/feature/orgs' into EPMRPP-90160

fd0cc6d

# Conflicts: # build.gradle

EPMRPP-90160 OrganizationController refactor

d549eb8

EPMRPP-90160 OrganizationController refactor

e0863e6

Merge branch 'refs/heads/feature/orgs' into EPMRPP-90249-roles-refactor

72ae7b5

# Conflicts: # build.gradle # project-properties.gradle # src/test/resources/db/migration/V001004__add_organizations.sql

github-actions bot reviewed May 15, 2024

View reviewed changes

APiankouski approved these changes May 15, 2024

View reviewed changes

grabsefx merged commit 89b6536 into feature/orgs May 15, 2024
6 of 7 checks passed

grabsefx deleted the EPMRPP-90249-roles-refactor branch May 15, 2024 10:39


		if (userPreferenceRepository.findByProjectIdAndUserIdAndFilterId(projectDetails.getProjectId(), user.getUserId(), filterId)
		if (userPreferenceRepository.findByProjectIdAndUserIdAndFilterId(membershipDetails.getProjectId(), user.getUserId(), filterId)

EPMRPP-90249 roles refactor #1987

EPMRPP-90249 roles refactor #1987

Conversation

grabsefx commented May 6, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot May 7, 2024

Choose a reason for hiding this comment

github-actions bot May 7, 2024

Choose a reason for hiding this comment

github-actions bot May 7, 2024

Choose a reason for hiding this comment

github-actions bot May 7, 2024

Choose a reason for hiding this comment