Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistant hash reporting #1981

Merged
merged 106 commits into from
Jul 10, 2024
Merged

Consistant hash reporting #1981

merged 106 commits into from
Jul 10, 2024

Conversation

pbortnik
Copy link
Collaborator

No description provided.

pbortnik and others added 30 commits October 2, 2023 14:03
…eue (#1822)

* EPMRPP-86359 || Implement pattern analyzer handling using rabbitmq queue

* EPMRPP-86361 || Add some checkstyle refactoring
* EPMRPP-86742 || extended launch import response
* EPMRPP-86742 || launch name fix
…erController (#1827)

* EPMRPP-84054 || Add DeprecatedUserController and updated route for UserController

* EPMRPP-84054 || Update DeprecatedUserController
* EPMRPP-86867 || updated logos in email templates
…1835)

* EPMRPP-80989 || Add attribute operator in duplicate operation check

* EPMRPP-80989 || Fix unit tests
…cture (#1834)

* EPMRPP-86867 || updated icons || re-organized template directory structure
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/main/java/com/epam/ta/reportportal/reporting/async/controller/TestItemConsistentHashAsyncController.java|91 col 80| Abbreviation in name 'startTestItemRQ' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/ta/reportportal/reporting/async/controller/TestItemConsistentHashAsyncController.java|103 col 81| Abbreviation in name 'finishExecutionRQ' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/ta/reportportal/reporting/async/consumer/ReportingConsumer.java|27| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/reporting/async/producer/LaunchFinishProducer.java|34| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/reporting/async/producer/LogProducer.java|44| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/reporting/async/producer/ItemFinishProducer.java|35| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/reporting/async/producer/LaunchStartProducer.java|35| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/reporting/async/producer/ItemStartProducer.java|36| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/TestConfig.java|53| Line is longer than 100 characters (found 107).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|19 col 5| Distance between variable 'suiteDescription' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|22| Line is longer than 100 characters (found 138).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|31 col 5| Distance between variable 'stepDescription' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|34| Line is longer than 100 characters (found 110).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|36| Line is longer than 100 characters (found 105).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|44 col 5| Distance between variable 'testDescription' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|47| Line is longer than 100 characters (found 133).
src/test/java/com/epam/ta/reportportal/demodata/service/ContentUtilsTest.java|59| Line is longer than 100 characters (found 103).

import org.springframework.web.bind.annotation.ResponseStatus;
import org.springframework.web.bind.annotation.RestController;

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
First sentence of Javadoc is missing an ending period.

String suiteDescription = ContentUtils.getSuiteDescription();
List<String> result = new ArrayList<>();
result.add(
"**This is demonstration description.** This `root-item` contains automatically generated test cases with logs and attachments.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 138).

String stepDescription = ContentUtils.getStepDescription();
List<String> result = new ArrayList<>();
result.add(
"This is the last **test case** of demo launch. There are only `logs` with `attachments` inside it.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 110).

import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.stereotype.Service;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

import org.springframework.stereotype.Service;
import org.springframework.web.multipart.MultipartFile;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

@@ -85,23 +86,27 @@
@ResponseStatus(CREATED)
@Operation(summary = "Starts launch for specified project")
public StartLaunchRS startLaunch(@PathVariable String projectName,
@Parameter(description = "Start launch request body", required = true) @RequestBody @Validated
StartLaunchRQ startLaunchRQ, @AuthenticationPrincipal ReportPortalUser user) {
@Parameter(description = "Start launch request body", required = true) @RequestBody @Validated StartLaunchRQ startLaunchRQ,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 129).

return finishLaunchHandler.finishLaunch(launchId, finishLaunchRQ,
projectExtractor.extractProjectDetails(user, normalizeId(projectName)), user,
@PathVariable String launchId,
@RequestBody @Validated FinishExecutionRQ finishLaunchRQ,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'finishLaunchRQ' must contain no more than '1' consecutive capital letters.

this.projectExtractor = projectExtractor;
this.createLogHandler = createLogHandler;
this.validator = validator;
}

/**
* @deprecated in favour of
* {@link LogAsyncController#createLogEntry(String, SaveLogRQ, ReportPortalUser)} because of
* mapping collisions
* {@link LogAsyncController#createLogEntry(String, SaveLogRQ, ReportPortalUser)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck> reported by reviewdog 🐶
Line continuation have incorrect indentation level, expected level should be 4.

* {@link LogAsyncController#createLogEntry(String, SaveLogRQ, ReportPortalUser)} because of
* mapping collisions
* {@link LogAsyncController#createLogEntry(String, SaveLogRQ, ReportPortalUser)}
* because of mapping collisions

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck> reported by reviewdog 🐶
Line continuation have incorrect indentation level, expected level should be 4.

() -> createLogHandlerAsync.sendMessage(request, binaryDataMetaInfo, 0L)
);
assertEquals(
"Error in handled Request. Please, check specified parameters: 'Launch UUID should not be null or empty.'",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 115).

return containers;
}

@Bean("retryListener")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> reported by reviewdog 🐶
Missing a Javadoc comment.

@pbortnik pbortnik marked this pull request as ready for review July 9, 2024 10:00
@pbortnik pbortnik requested a review from avarabyeu as a code owner July 9, 2024 10:00
@pbortnik pbortnik changed the title Draft/consistant hash reporting Consistant hash reporting Jul 9, 2024
@pbortnik pbortnik merged commit 148cae5 into develop Jul 10, 2024
6 checks passed
@pbortnik pbortnik deleted the draft/consistant_hash_reporting branch July 10, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants