Add wildcard support to webchannels #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhackett1024
approved these changes
Dec 15, 2023
|
Noting that I'm not merging this yet because the builds are broken for linux and windows so I can't verify it fully. I have RUN-3043 open to fix the build but with @jazzdan and I out for the next week, it's likely this won't be resolved before then. If someone does pick it and and fix the build, then this can be merged and released. I've tested it on Mac so I'm fairly confident it'll work on all platforms. |
|
Are we unblocked to merge this now @ryanjduffy / @bhackett1024? |
Builds we're still broken last I tried but I can check again |
jazzdan
force-pushed
the
ryan/scs-1714-cannot-log-into-legacyreplayio-from-the-replay-browser
branch
from
f6c3287
to
69ed27e
Compare
ryanjduffy
deleted the
ryan/scs-1714-cannot-log-into-legacyreplayio-from-the-replay-browser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for wildcard URIs for WebChannels so we can forward auth to custom sub-domains of replay.io (like
legacy.replay.io)