Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not updated links on multiple file insert when AutoRename is enabled #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix not updated links on multiple file insert when AutoRename is enabled #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 12 additions & 15 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,13 @@ export default class PasteImageRenamePlugin extends Plugin {
this.openRenameModal(file, isMeaningful ? stem : '', activeFile.path)
return
}
this.renameFile(file, newName, activeFile.path, true)

const editor = this.getActiveEditor()
const cursor = editor?.getCursor()
await this.renameFile(file, newName, activeFile.path, editor, cursor)
}

async renameFile(file: TFile, inputNewName: string, sourcePath: string, replaceCurrentLine?: boolean) {
async renameFile(file: TFile, inputNewName: string, sourcePath: string, editor?: any, cursor?: any) {
// deduplicate name
const { name:newName } = await this.deduplicateNewName(inputNewName, file)
debugLog('deduplicated newName:', newName)
Expand All @@ -165,27 +168,19 @@ export default class PasteImageRenamePlugin extends Plugin {
throw err
}

if (!replaceCurrentLine) {
if (!editor || !cursor) {
debugLog('editor or cursor was not given, wont attempt manual link replacement', newName, editor, cursor)
return
}

// in case fileManager.renameFile may not update the internal link in the active file,
// we manually replace the current line by manipulating the editor

const newLinkText = this.app.fileManager.generateMarkdownLink(file, sourcePath)
debugLog('replace text', linkText, newLinkText)

const editor = this.getActiveEditor()
if (!editor) {
new Notice(`Failed to rename ${newName}: no active editor`)
return
}

const cursor = editor.getCursor()
const line = editor.getLine(cursor.line)
const replacedLine = line.replace(linkText, newLinkText)
debugLog('current line -> replaced line', line, replacedLine)
// console.log('editor context', cursor, )
debugLog('[cursor position] current line -> replaced line:', `[${cursor.line}, ${cursor.ch}] ${line} -> ${replacedLine}`)
editor.transaction({
changes: [
{
Expand All @@ -206,7 +201,9 @@ export default class PasteImageRenamePlugin extends Plugin {
this.app, file as TFile, newName,
(confirmedName: string) => {
debugLog('confirmedName:', confirmedName)
this.renameFile(file, confirmedName, sourcePath, true)
const editor = this.getActiveEditor()
const cursor = editor?.getCursor()
this.renameFile(file, confirmedName, sourcePath, editor, cursor)
},
() => {
this.modals.splice(this.modals.indexOf(modal), 1)
Expand Down Expand Up @@ -257,7 +254,7 @@ export default class PasteImageRenamePlugin extends Plugin {
break;
}

await this.renameFile(file, newName, activeFile.path, false)
await this.renameFile(file, newName, activeFile.path)
}
}

Expand Down