forked from adityatelange/hugo-PaperMod
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge PRs and PaperMod commits after the fork #31
Open
dunklecat
wants to merge
82
commits into
reorx:master
Choose a base branch
from
dunklecat:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding go module was broken: > module declares its path as: github.com/adityatelange/hugo-PaperMod but was required as: github.com/reorx/hugo-PaperModX This should fix it.
Signed-off-by: Triple-Z <[email protected]>
theme vars fix
make the background color of selected text consistent with the overal…
Updates go.mod to match fork
feat: add share buttons back 🎉
* Updated post-single.css to set hr's border to 0 * cleanup Co-authored-by: Aditya Telange <[email protected]>
…telange#886) Moves "Translations" word out of `ul`
Thanks to https://www.iconfinder.com/icons/4691462/strava_icon for the icon Co-authored-by: Matt Burns <[email protected]>
Updated translations to use a more correct french (such as good use of capital letter or spacing with special characters)
"Next Page" -> "Next" & "Prev Page" -> "Prev" For adityatelange#914
- adds the ability to use the noindex and nofollow parameters for specific pages in production mode, preventing e.g. the imprint from showing up in search engines. - Usage: In post front-matter add, --- robotsNoIndex: true ---
Fix Bad value 15px for attribute height on element img: Expected a digit but saw p instead.
* 💄 Update Icons - add Icon for Micro.blog - add Icon for xmpp - add Icon for session messenger - update Steam Icon to fit to line icon style of papermod-theme Signed-off-by: Achim Krämer <[email protected]> * refactor alphabetically Co-authored-by: Aditya Telange <[email protected]>
considering "iconic images that are redundant with text next to them or purely decorative should have alt="" instead." from https://validator.w3.org/
Usage => Params.label.iconSVG: "<your SVG as a string>"
Co-authored-by: Aditya Telange <[email protected]>
"পরবর্তী পাতা" -> "পরবর্তী" & "পূর্বের পাতা" -> "পূর্ববর্তী"
In site config => Params: ShowPageNums: true
* Add DeviantArt social icon * Add Patreon social icon
Usage => --- title: post name hiddenInHomeList: true ---
Removes line break from generated HTML output. This line break renders in browsers as an unwanted space.
* Add anilist logo * Add osu logo
super minor fix for spotify icon, basically no change in functionality typo in 'stoke' but it looks better without that way anyways so i just changed it to none
Add Repo/Source where this issue can be reproduced
when imageUrl was set with external link resources.Get throws an error Ref: gohugoio/hugo@22ef5da fixes: adityatelange#1019
New Features : Add Giscus comments support
dunklecat
changed the title
Merge PRs and PaperMod commits after the merge
Merge PRs and PaperMod commits after the fork
Oct 9, 2022
I have a question: is the ultimate goal to bring the improvements of PaperModX to PaperMod? |
hmajid2301
added a commit
to hmajid2301/hugo-PaperModX
that referenced
this pull request
Nov 13, 2022
- Fix syntax highlighting especially light theme looked bad - Change the name of admonitions to notice. Also tidy up the code so there is less repeated code - Updated colours in themes, to be easier to read - Add icon next to views - Move page view into its own partial file Fixes: reorx#31, reorx#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I like this theme a lot, as it is the perfect improvement to PaperMod in my opinion. On the other hand I saw that the latter had some refinement after your fork: some optimizations, some extra icons, some adjustments... moreover a couple of interesting PRs emerges around here, too.
I spent the last two days trying to merge and test everything from them, trying to keep your code as clean and coherent as possible. I'm not saying this is a perfect work, but I believe a lot of changes this PR brings are positive ones. Furthermore I'm no front-end expert, I'm just trying to improve this awesome theme.
PRs:
#17 #23 #24 #27 #29