Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PRs and PaperMod commits after the fork #31

Open
wants to merge 82 commits into
base: master
Choose a base branch
from

Conversation

dunklecat
Copy link

@dunklecat dunklecat commented Oct 9, 2022

Hi all,

I like this theme a lot, as it is the perfect improvement to PaperMod in my opinion. On the other hand I saw that the latter had some refinement after your fork: some optimizations, some extra icons, some adjustments... moreover a couple of interesting PRs emerges around here, too.

I spent the last two days trying to merge and test everything from them, trying to keep your code as clean and coherent as possible. I'm not saying this is a perfect work, but I believe a lot of changes this PR brings are positive ones. Furthermore I'm no front-end expert, I'm just trying to improve this awesome theme.

PRs:
#17 #23 #24 #27 #29

SavingNinja and others added 30 commits July 2, 2022 11:13
Adding go module was broken:

> module declares its path as: github.com/adityatelange/hugo-PaperMod
	        but was required as: github.com/reorx/hugo-PaperModX

This should fix it.
make the background color of selected text consistent with the overal…
Updates go.mod to match fork
feat: add share buttons back 🎉
* Updated post-single.css to set hr's border to 0

* cleanup

Co-authored-by: Aditya Telange <[email protected]>
Updated translations to use a more correct french (such as good use of capital letter or spacing with special characters)
"Next Page" -> "Next" & "Prev Page" -> "Prev"
For adityatelange#914
- adds the ability to use the noindex and nofollow parameters for specific pages in production mode, preventing e.g. the imprint from showing up in search engines.
- Usage: In post front-matter add,
    ---
    robotsNoIndex: true
    ---
adityatelange and others added 26 commits October 9, 2022 15:17
Fix Bad value 15px for attribute height on element img: Expected a digit but saw p instead.
* 💄 Update Icons

- add Icon for Micro.blog
- add Icon for xmpp
- add Icon for session messenger
- update Steam Icon to fit to line icon style of papermod-theme

Signed-off-by: Achim Krämer <[email protected]>

* refactor alphabetically

Co-authored-by: Aditya Telange <[email protected]>
considering "iconic images that are redundant with text next to them or purely decorative should have alt="" instead."
from https://validator.w3.org/
Usage =>
Params.label.iconSVG: "<your SVG as a string>"
"পরবর্তী পাতা" -> "পরবর্তী" & "পূর্বের পাতা" -> "পূর্ববর্তী"
In site config =>
Params:
    ShowPageNums: true
* Add DeviantArt social icon

* Add Patreon social icon
Usage =>
---
title: post name
hiddenInHomeList: true
---
Removes line break from generated HTML output. This line break renders in browsers as an unwanted space.
super minor fix for spotify icon, basically no change in functionality

typo in 'stoke' but it looks better without that way anyways so i just changed it to none
Add Repo/Source where this issue can be reproduced
when imageUrl was set with external link resources.Get throws an error

Ref: gohugoio/hugo@22ef5da

fixes: adityatelange#1019
New Features : Add Giscus comments support
@dunklecat dunklecat changed the title Merge PRs and PaperMod commits after the merge Merge PRs and PaperMod commits after the fork Oct 9, 2022
@dunklecat
Copy link
Author

I have a question: is the ultimate goal to bring the improvements of PaperModX to PaperMod?

hmajid2301 added a commit to hmajid2301/hugo-PaperModX that referenced this pull request Nov 13, 2022
- Fix syntax highlighting especially light theme looked bad

- Change the name of admonitions to notice.
Also tidy up the code so there is less repeated code

- Updated colours in themes, to be easier to read

- Add icon next to views

- Move page view into its own partial file

Fixes: reorx#31, reorx#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.