Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets/custom-managers): Expand acceptable datasource names #33677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bpfoster
Copy link
Contributor

Changes

Datasource names used in the following custom manager presets can now include uppercase letters, numbers, and underscores (_):

  • bitbucketPipelinesVersions
  • dockerfileVersions
  • githubActionsVersions
  • gitlabPipelineVersions
  • makefileVersions
  • mavenPropertyVersions

Context

This was brought up in discussion #33643

I have expanded the regex minimally to err on the safe side. Would it be beneficial to open it up even more?

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Datasource names used in the following custom manager presets can now include uppercase letters, numbers, and underscores (_):
- bitbucketPipelinesVersions
- dockerfileVersions
- githubActionsVersions
- gitlabPipelineVersions
- makefileVersions
- mavenPropertyVersions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants