feat(manager): add devbox manager module #33638
Open
+719
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
previously approved these changes
Jan 16, 2025
viceice
reviewed
Jan 16, 2025
| }; | ||
|
|
||
| let cmd = ''; | ||
| if (updateConfig.config.isLockFileMaintenance) { |
There was a problem hiding this comment.
you need an additional check
renovate/lib/modules/manager/bun/artifacts.ts
Lines 20 to 25 in 3cae4d8
There was a problem hiding this comment.
☝️ ❓ There are edge cases where config.isLockFileMaintenance === false but config.updateType === 'lockFileMaintenance'
viceice
reviewed
Jan 17, 2025
| }; | ||
|
|
||
| let cmd = ''; | ||
| if (updateConfig.config.isLockFileMaintenance) { |
There was a problem hiding this comment.
☝️ ❓ There are edge cases where config.isLockFileMaintenance === false but config.updateType === 'lockFileMaintenance'
| datasource: 'devbox', | ||
| depName: 'nodejs', | ||
| packageName: 'nodejs', | ||
| skipReason: 'invalid-version', |
| return { deps }; | ||
| } | ||
|
|
||
| return null; |
| }), | ||
| ); | ||
|
|
||
| export type DevboxFile = z.infer<typeof DevboxFile>; |
There was a problem hiding this comment.
Suggested change
| export type DevboxFile = z.infer<typeof DevboxFile>; |
unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the devbox manager, https://www.jetify.com/devbox. Devbox is a local development tool which creates local reproducible environments without docker containers.
Context
This PR is related to #30002
where I was asked to split that PR into one for the versioning, datasource and manager.
I am making these changes on behalf of Culture Amp as we are using renovate internally and have recently migrated to using devbox for our local developer environments.
This PR will ensure that all of our devbox.json files stay up to date with the rest of our repos.
#27543
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: