Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(manager/gomod): Update go version to 1.23.3 in tests/examples #32514

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

echarrod
Copy link
Contributor

@echarrod echarrod commented Nov 13, 2024

Changes

  • Update Go version to 1.23

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@echarrod echarrod changed the title Ed update go version feat(manager/gomod): Update go version to 1.23.3 Nov 13, 2024
@echarrod echarrod marked this pull request as ready for review November 13, 2024 14:20
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these changes makes any difference to how Renovate behaves at runtime

@echarrod
Copy link
Contributor Author

None of these changes makes any difference to how Renovate behaves at runtime

I just thought it would be more familiar for users to see an up to date Go version in the docs, that they would be using, and thought we might as well run the tests against a later Go version specified

@rarkins rarkins changed the title feat(manager/gomod): Update go version to 1.23.3 chore(manager/gomod): Update go version to 1.23.3 in tests/examples Nov 13, 2024
@rarkins
Copy link
Collaborator

rarkins commented Nov 13, 2024

OK, I've updated this from feat to chore

@rarkins rarkins added this pull request to the merge queue Nov 13, 2024
Merged via the queue into renovatebot:main with commit 894250d Nov 13, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -133,4 +133,3 @@ replace (
)

toolchain go1.22.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed, ho would remove it. should never lower than go directive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in #32546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants