refactor(manager/cargo): use zod to parse manifest/config
#31260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
force-pushed
the
refactor/use-zod-cargo
branch
from
d2d0493
to
c0b8711
Compare
viceice
reviewed
Sep 7, 2024
viceice
reviewed
Sep 30, 2024
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
rarkins
previously approved these changes
Oct 1, 2024
viceice
reviewed
Oct 1, 2024
Co-authored-by: Michael Kriese <[email protected]>
viceice
reviewed
Oct 2, 2024
viceice
approved these changes
Oct 2, 2024
|
🎉 This PR is included in version 38.134.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move parsing of
cargomanifest and config tozod, as preliminary steps for adding new features.Context
Wanted to add support for git dependencies in
cargo, but it felt like we could benefit from moving the parsing of manifest and config tozodbefore adding new features. I'm not an expert in usingzodso I hope the changes make sense.I tried to split the commits in a meaningful way, since the changes are incremental. If you feel that the PR is too big, let me know, I'd be happy to split it.
There's a pretty strong test suite for the different features we support for the manager, so I trust that they show the refactoring does not break any existing feature, but if needed, I can test the changes on a real repository as well, just let me know.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: