Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geckoboard.md #483

Merged
merged 3 commits into from
Oct 16, 2018
Merged

Update geckoboard.md #483

merged 3 commits into from
Oct 16, 2018

Conversation

Nirvikalpa108
Copy link
Contributor

@Nirvikalpa108 Nirvikalpa108 commented Oct 16, 2018

This is a modified version of the Contributing Guidelines.

This pull request adheres to the repository's Code of Conduct.

  • I am an employee of the company mentioned and confirm all included details are correct
  • This PR contains housekeeping only (URL edits, copy changes etc)
  • You know your alphabet - company is listed in alphabetical order in the README
  • The company directly hires employees. No bootcamps / freelance sites / etc
  • The company added hires remote employees, or positions are available to remote workers and are clearly illustrated as such
  • A company profile is included - Required for new additions. (This can be a basic outline but at least something please)
  • Remote status has details regarding how the culture includes remote employees, how the company integrated remote workers, etc
  • Region details any restrictions to applicants based on geography
  • How to apply details the best approach for new applications, page on site where open position are listed, and any other help available for job hunters

@auto-nylen
Copy link

Hi @Nirvikalpa108, thanks for your contribution!

Our automated checks detected some problems with this pull request (as of commit 78ef605). See below for details:

geckoboard.md: Profile looks complete, but the main readme contains a warning emoji.

1 problem detected

Please fix these issues and push a new commit to this pull request.


## Region

Headquartered in London, but with team members across the world.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the company is open to hiring globally, please make this Worldwide. The location is under Office Locations as you've mentioned

@dougaitken
Copy link
Member

Hey @Nirvikalpa108 - thanks for opening this Pull Request to update the Geckoboard listing!

What the bot is complaining about is that in the main README.md file, you'll see the ⚠️emoji. We use this to indicate that a company doesn't have a profile. So now you've added the profile, the bot is confused why the emoji is still there.

geckoboard_warning

If you can edit your pull request to remove that ⚠️from next to geckoboard on the main README file, and then link to the company profile, we'll get it merged.

If you're not sure how, just let us know

@auto-nylen
Copy link

Hi @nylen, thanks for updating the pull request! According to our automated checks, everything looks OK now (as of commit cf43752). ✔️

@nylen
Copy link
Collaborator

nylen commented Oct 16, 2018

Thanks for the PR! I've fixed up the readme and the region field.

@nylen nylen merged commit 3ae9b9d into remoteintech:master Oct 16, 2018
@Nirvikalpa108
Copy link
Contributor Author

Hi @dougaitken, I just want to say a huge thank you for responding to my question and teaching me how to address the error message. I'll try to practice changing the README file along with the company profile for next time. Thank you very much indeed.

Thanks for fixing @nylen. I'm not sure about the wording in the region field which is currently "Worldwide, with team members across the world." It seems to be a repetition. Perhaps just having the world "Worldwide" alone would be sufficient? It's a small point, so understand if you prefer not to change!
Thank you again!

@nylen
Copy link
Collaborator

nylen commented Oct 17, 2018

Huh, you're right, I didn't do a great job there. I'll fix it tomorrow, or if you want to try your hand at another PR, I agree it should just be Worldwide.

The Region field in general is a bit messy at the moment. To me there is not a good reason to have this in both the readme and the company profile. We're discussing this more general issue at #485 and would love to hear what you and others think too.

nylen added a commit that referenced this pull request Oct 18, 2018
Quick follow-up to #483.
@nylen nylen mentioned this pull request Oct 18, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants