-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update geckoboard.md #483
Update geckoboard.md #483
Conversation
Hi @Nirvikalpa108, thanks for your contribution! Our automated checks detected some problems with this pull request (as of commit 78ef605). See below for details:
Please fix these issues and push a new commit to this pull request. |
company-profiles/geckoboard.md
Outdated
|
||
## Region | ||
|
||
Headquartered in London, but with team members across the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the company is open to hiring globally, please make this Worldwide
. The location is under Office Locations as you've mentioned
Hey @Nirvikalpa108 - thanks for opening this Pull Request to update the Geckoboard listing! What the bot is complaining about is that in the main README.md file, you'll see the If you can edit your pull request to remove that If you're not sure how, just let us know |
Thanks for the PR! I've fixed up the readme and the region field. |
Hi @dougaitken, I just want to say a huge thank you for responding to my question and teaching me how to address the error message. I'll try to practice changing the README file along with the company profile for next time. Thank you very much indeed. Thanks for fixing @nylen. I'm not sure about the wording in the region field which is currently "Worldwide, with team members across the world." It seems to be a repetition. Perhaps just having the world "Worldwide" alone would be sufficient? It's a small point, so understand if you prefer not to change! |
Huh, you're right, I didn't do a great job there. I'll fix it tomorrow, or if you want to try your hand at another PR, I agree it should just be Worldwide. The Region field in general is a bit messy at the moment. To me there is not a good reason to have this in both the readme and the company profile. We're discussing this more general issue at #485 and would love to hear what you and others think too. |
This is a modified version of the Contributing Guidelines.
This pull request adheres to the repository's Code of Conduct.