Clean up + add support for rustls builds #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had no CI running for rollbar-rs, nor any Makefil with lints, format checks, etc.
isobit
reviewed
Apr 11, 2023
aengelas
changed the title
isobit
reviewed
Apr 11, 2023
| ] } | ||
| hyper-rustls = { version = "0.24", default-features = false, features = [ | ||
| "http1", | ||
| "rustls-native-certs", |
There was a problem hiding this comment.
Probably doesn't matter that much, but curious if this (rustls-native-certs) is actually required, or if we should omit it and leave it up to the lib user.
Comment on lines
+570
to
+572
| .with_native_roots() | ||
| .https_only() | ||
| .enable_http1() |
There was a problem hiding this comment.
Do we for sure need to configure all this? Unclear to me looking at the docs what the defaults are...
| .PHONY: lint | ||
| lint: | ||
| cargo fmt -- --check | ||
| cargo +nightly clippy -- -Wclippy::pedantic |
|
|
||
| .PHONY: doc | ||
| doc: | ||
| $(MAKE) -B target/doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This all started as an attempt to get this crate to use rustls (working on pruning away native libs from hq), but this repo wound up needing some love.