External Splices repo + GHCJS splices #787
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To note the diffs will be pretty much useless until I make a new branch after I've disabled nixpkgs-fmt in my editor! |
Ericson2314
reviewed
Jun 30, 2022
default.nix
Outdated
Comment on lines
3
to
6
| , config ? { | ||
| android_sdk.accept_license = true; | ||
| } |
There was a problem hiding this comment.
We only do this in release.nix on purpose, as we cannot opt into the license on behalf of our users.
There was a problem hiding this comment.
Feel free to add some sort of comment so this is clear to the next person to edit this file.
There was a problem hiding this comment.
Sorry, leftover from local testing.
Yes any mass formatting changes should always be done in a separate PR, if at all. |
cidkidnix
force-pushed
the
dylang/external-splices-loading-nix
branch
from
d77247a to
4452db0
Compare
cidkidnix
force-pushed
the
dylang/external-splices-loading-nix
branch
from
4452db0 to
7712970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Switch splices-load-save.nix to a thunk
Depends on #788