Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somewhat modernize CI version range #479

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

alexfmpe
Copy link
Member

No description provided.

@alexfmpe alexfmpe force-pushed the ci-versions branch 3 times, most recently from 2bf7511 to 5f2f697 Compare November 22, 2024 20:45
@alexfmpe alexfmpe changed the title Modernize CI version range Somewhat modernize CI version range Nov 22, 2024
@alexfmpe
Copy link
Member Author

alexfmpe commented Nov 22, 2024

Passing hlint test suite on 9.4+ needs #474

@alexfmpe alexfmpe force-pushed the ci-versions branch 3 times, most recently from 46de32d to c681315 Compare November 23, 2024 01:24
Copy link
Contributor

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as the tests pass.

@alexfmpe alexfmpe force-pushed the ci-versions branch 3 times, most recently from 6d6443b to 06c2ae4 Compare December 2, 2024 01:01
@alexfmpe
Copy link
Member Author

alexfmpe commented Dec 2, 2024

I don't know why, but the github action keeps failing to install 8.8.4 on macos.
Switching to linux only got it green again

@maralorn maralorn merged commit f7a50ac into reflex-frp:develop Dec 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants