Unification of mount state PRs #305
Conversation
…DomBuilder also clean up some code around the immediate dom builder, and add some doc comments compiles but needs testing
…s and fix the instance for ImmediateDomBuilderT use the compiler, luke. *shakes fist at cabal*
also export MonadWidgetConstraints so it shows up in haddock
… and replace with TODO to possibly remove it
…ns, use pattern matching to be as strict as the previous version
# Conflicts: # reflex-dom-core/src/Reflex/Dom/Builder/Immediate.hs # reflex-dom-core/src/Reflex/Dom/Main.hs
…ents-refactor * origin/dn-add-mount-state: Fix INLINE, and strictness fix build errors after merge resolve merge conflict in Immediate.hs address hlint complaints about extra parens rename MonadMountStatus to HasMountStatus change "action" to "widget" in MonadMountStatus documentation add space before MountState constructor list to be consistent instead of using a composition to weaken child map to get installations, use pattern matching switch to ragged alignment remove duplicate comment remove speculation about purpose for _immediateDomBuilderEnv_document and replace with TODO to possibly remove it don't use ViewPatterns for the few one-offs but instead use named field binding add caution about Unmounted being harder to see add lift instances of MonadMountStatus for ReaderT and PostBuildT add MonadMountStatus to MonadWidget remove (Reflex t, Monad m) superclass constraint from MonadMountStatus and fix the instance for ImmediateDomBuilderT instance MonadMountStatus for ImmediateDomBuilderT fix typo in doc comment support reporting of DOM mount state via Dynamic when using ImmediateDomBuilder
|
This contains #271 and #273 so far. #273 uses a The options now are: Regardless of which of these options we select, the next step will be to merge I'm going to pursue option (a) - it gets us most of the benefit without the cost. |
|
I agree that Event-based API seems sufficient for the cases I've encountered. I can't recall if it includes "Unmounted" event? If so we can create the dynamic ourselves when needed. |
…nt-state-merge * origin/dn-getmounted-event: Add tests for traverseDMapWithKeyWithAdjustWithMove, comments, fixes Add more tests for traverseDMapWithKeyWithAdjust Add instances of HasMountStatus for other classes Add traverseDMapWithKeyWithAdjust tests Add tests for runWithReplace Add mountedEvent testcase Fix slowdown by inline Add getMounted Event
|
Is someone still working on this? |
|
It was paused as we fixed some hydration issues. I'll have a look at the conflicts with develop and hopefully get this merged very soon. |
lpsmith
added
enhancement
breaking change
clean up
|
Any recent updates on this? I'm attempting to implement a wrapper around the Material Design Components for the web https://material.io/develop/web/ and am a bit stuck figuring out how to handle calling the clean up methods on the components that need them. |
|
If someone were to pick this up, what is left to do? Obviously resolve merge conflicts. If it were me I would also add an unmount event. Is there anything else that needs to be done? |
|
Are there any update on this? |
|
ping. It's currently difficult interface with several of the web-API methods (eg: https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView) because there's no way to check if something actually exists in the DOM. |
No description provided.