Add DomHasCallStack for ghcjs-dom debug feature #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending performance testing. |
hamishmack
force-pushed
the
ghcjs-dom-debug
branch
from
a3ae1ee to
f26d424
Compare
hSloan
added
enhancement
opinionated
|
Per https://github.com/ghcjs/ghcjs-dom/blob/master/README.md#adding-domhascallstack-constraint there should be no performance issues when that library doesn't have debugging. So maybe this is good and we just need to change reflex platform to make sure that flag is off in release builds? |
|
https://github.com/ghcjs/ghcjs-dom/blob/master/ghcjs-dom/ghcjs-dom.cabal#L28 at least currently, it's off by default. |
|
There are other things to worry about, though. "Debug levels" are rarely composable, and debugging a library and debugging something using a library is rather different. It's not clear how this stuff works with reflex, but I trust @hamishmack to have tried it out and gotten value :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ghcjs/ghcjs-dom/blob/master/README.md#debug