[IMPL] - added support for sass and scss stylesheet languages #4292
Conversation
- better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file
|
Sorry, that's why I can't see the error... Unit tests, cp312
Unit tests, cp310
|
Units tests
|
|
well, for the |
| @@ -165,7 +239,7 @@ def test_compile_stylesheets_exclude_tailwind(tmp_path, mocker): | |||
|
|
|||
| assert compiler.compile_root_stylesheet(stylesheets) == ( | |||
| str(Path(".web") / "styles" / "styles.css"), | |||
| "@import url('../public/styles.css'); \n", | |||
| "@import url('./styles.css'); \n", | |||
There was a problem hiding this comment.
are you sure this won't break anything?
There was a problem hiding this comment.
I don't know where this could cause a problem, since all the supported stylesheet files in the app/assets directories and subdirectories are copied or compiled and saved in the .web/styles directory and no longer in the .web/public directories.
and also, I checked the second batch of the tests/integration group and the tests/integration/test_tailwind.py (which is the only one to have tests impacted by the changes) passed the tests without any errors, which is why I don't understand the error in the first batch of the tests/integration group.
- better checking of stylesheets to be compiled - added support for sass and scss stylesheet languages - the stylesheets files are now copied to ".web/styles/" at compile time - relock poetry file for libsass deps - stylesheet compiler unit tests also check the contents of the file
…/KronosDev-Pro/reflex into add-sass-scss-stylesheet-support
All Submissions:
Type of change
New Feature Submission:
Changes To Core Features: