Skip to content

Commit

Permalink
Temporarily downpin @radix-ui/themes <3.1.5 (#4370)
Browse files Browse the repository at this point in the history
* Temporarily downpin @radix-ui/themes <3.1.5

A visual/style regression was introduced in @radix-ui/themes 3.1.5
as described in radix-ui/themes#627 which reflex needs to avoid.

* Get expected radix library version from component
  • Loading branch information
masenf committed Nov 12, 2024
1 parent 1f7e7af commit 593ec23
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions reflex/components/radix/themes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ class RadixThemesComponent(Component):

library = "@radix-ui/themes@^3.0.0"

# Temporary pin < 3.1.5 until radix-ui/themes#627 is resolved.
library = library + " && <3.1.5"

# "Fake" prop color_scheme is used to avoid shadowing CSS prop "color".
_rename_props: Dict[str, str] = {"colorScheme": "color"}

Expand Down
5 changes: 3 additions & 2 deletions tests/units/components/core/test_banner.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
ConnectionPulser,
WebsocketTargetURL,
)
from reflex.components.radix.themes.base import RadixThemesComponent
from reflex.components.radix.themes.typography.text import Text


Expand All @@ -24,7 +25,7 @@ def test_connection_banner():
"react",
"$/utils/context",
"$/utils/state",
"@radix-ui/themes@^3.0.0",
RadixThemesComponent().library or "",
"$/env.json",
)
)
Expand All @@ -42,7 +43,7 @@ def test_connection_modal():
"react",
"$/utils/context",
"$/utils/state",
"@radix-ui/themes@^3.0.0",
RadixThemesComponent().library or "",
"$/env.json",
)
)
Expand Down

0 comments on commit 593ec23

Please sign in to comment.