Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude menu and TOC items from the visited link styles for better UX #4761

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Ahmed-Hakeem
Copy link
Contributor

for better UX, menu and TOC items style should indicate only one thing, which is the current read item

When you click on an item and then scroll to another .... notice: the prev item still having the same style as the current one.

image

for better UX, menu and TOC items style should indicate only one thing, which is the current read item
Copy link

codesandbox-ci bot commented Dec 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit 75ee75f
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/675ff24f7809110008ef23b1
😎 Deploy Preview https://deploy-preview-4761--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ahmed-Hakeem
Copy link
Contributor Author

I guess we need the same for the navbar menu... I will include it as well

@timdorr
Copy link
Member

timdorr commented Dec 16, 2024

Thank you!

@timdorr timdorr merged commit 2e65479 into reduxjs:master Dec 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants