-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Expo and React Native examples to CI #4681
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…-and-expo-to-ci
✅ Deploy Preview for redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can we add any caching to this to speed things up? This slows the test suite by nearly 5x and this library isn't React-specific. This seems like overkill to me. |
@timdorr Sure I can figure out some sort of caching to speed this up. |
Updated the RN examples upstream to be much much faster, but also added a cache. Thanks for getting this together! |
That's awesome, thank you Tim! This makes me wonder, would it be okay then to re-open reduxjs/redux-thunk#365? |
Unfortunately, I can't reopen that PR (branch is deleted). But feel free to submit a new one and we'll get it merged in. |
@timdorr Thank you!!! |
i reopened it 👍🏻 |
@EskiMojo14 Thank you Ben! |
Co-authored-by: Tim Dorr <[email protected]> Co-authored-by: Tim Dorr <[email protected]>
This PR: